OPNsense
  • Home
  • Help
  • Search
  • Login
  • Register

  • OPNsense Forum »
  • English Forums »
  • Development and Code Review (Moderator: fabian) »
  • Cicada Theme -> Franco didnt want the cicada theme - so deleted!
« previous next »
  • Print
Pages: [1] 2 3 ... 5

Author Topic: Cicada Theme -> Franco didnt want the cicada theme - so deleted!  (Read 29456 times)

opnsense_user12123

  • Guest
Cicada Theme -> Franco didnt want the cicada theme - so deleted!
« on: March 07, 2018, 07:40:00 pm »
Because franco did not want two "dark themes". Even though both themes are totally different and he did not even test it, I have asked him to ask the community to decide which theme would be included as a new theme in the original repo of opnsense in the future.
But on my suggestion, he did not even enter, although I would have found this to be fair!

So unfortunately I have to delete the cicada theme.
So use the "dark theme" instead! ->Although it looks cheap but is created by a friend and profi of franco . thus the right decision for franco!

At the end 3 months of work for nothing and an imaginary programmer who destroys all my work.
Franco is a great admin and a person who knows how to motivate people.

I just want to warn everyone who volunteers to volunteer and invest time here.
It might be pretty conceited people here.
i´m back to PFSENSE !
« Last Edit: March 27, 2018, 05:06:15 pm by opnsense_user12123 »
Logged

opnsense_user12123

  • Guest
Re: Cicada Template short preview
« Reply #1 on: March 08, 2018, 06:08:01 am »
.
« Last Edit: March 27, 2018, 03:56:36 pm by opnsense_user12123 »
Logged

elektroinside

  • Hero Member
  • *****
  • Posts: 574
  • Karma: 51
    • View Profile
Re: [Template / Cicada] - short preview
« Reply #2 on: March 08, 2018, 07:09:32 am »
This looks very nice! Great job!
Logged
OPNsense v18 | HW: Gigabyte Z370N-WIFI, i3-8100, 8GB RAM, 60GB SSD, | Controllers: 82575GB-quad, 82574, I221, I219-V | PPPoE: RDS Romania | Down: 980Mbit/s | Up: 500Mbit/s

Team Rebellion Member

opnsense_user12123

  • Guest
Re: [Template / Cicada] - short preview
« Reply #3 on: March 08, 2018, 06:47:02 pm »
.
« Last Edit: March 27, 2018, 03:56:45 pm by opnsense_user12123 »
Logged

opnsense_user12123

  • Guest
Re: [Template / Cicada] - short preview
« Reply #4 on: March 10, 2018, 12:31:22 pm »
.
« Last Edit: March 27, 2018, 03:57:12 pm by opnsense_user12123 »
Logged

fabian

  • Moderator
  • Hero Member
  • *****
  • Posts: 2769
  • Karma: 200
  • OPNsense Contributor (Language, VPN, Proxy, etc.)
    • View Profile
    • Personal Homepage
Re: [Template / Cicada] - short preview
« Reply #5 on: March 10, 2018, 01:54:14 pm »
I do not like this code - looks like really bad quality.
Logged

opnsense_user12123

  • Guest
Re: [Template / Cicada] - short preview
« Reply #6 on: March 10, 2018, 06:48:18 pm »
.
« Last Edit: March 27, 2018, 03:57:18 pm by opnsense_user12123 »
Logged

fabian

  • Moderator
  • Hero Member
  • *****
  • Posts: 2769
  • Karma: 200
  • OPNsense Contributor (Language, VPN, Proxy, etc.)
    • View Profile
    • Personal Homepage
Re: [Template / Cicada] - short preview
« Reply #7 on: March 10, 2018, 07:06:36 pm »
Quote from: opnsense_user12123 on March 10, 2018, 06:48:18 pm
please feedback me!
Not your code, have not looked yet on it - the JS code for the calendar is bad.
Logged

opnsense_user12123

  • Guest
Re: [Template / Cicada] - short preview
« Reply #8 on: March 10, 2018, 07:07:21 pm »
.
« Last Edit: March 27, 2018, 03:57:24 pm by opnsense_user12123 »
Logged

opnsense_user12123

  • Guest
Re: [Template / Cicada] - short preview
« Reply #9 on: March 10, 2018, 07:19:26 pm »
.
« Last Edit: March 27, 2018, 05:06:53 pm by opnsense_user12123 »
Logged

fabian

  • Moderator
  • Hero Member
  • *****
  • Posts: 2769
  • Karma: 200
  • OPNsense Contributor (Language, VPN, Proxy, etc.)
    • View Profile
    • Personal Homepage
Re: [Template / Cicada] - short preview
« Reply #10 on: March 10, 2018, 07:22:39 pm »

Isn't that correct?
https://github.com/opnsense/plugins/compare/master...opnsenseuser12123:master?expand=1
Logged

opnsense_user12123

  • Guest
Re: [Template / Cicada] - short preview
« Reply #11 on: March 10, 2018, 07:27:14 pm »
.
« Last Edit: March 27, 2018, 05:07:06 pm by opnsense_user12123 »
Logged

fabian

  • Moderator
  • Hero Member
  • *****
  • Posts: 2769
  • Karma: 200
  • OPNsense Contributor (Language, VPN, Proxy, etc.)
    • View Profile
    • Personal Homepage
Re: [Template / Cicada] - short preview
« Reply #12 on: March 10, 2018, 07:29:17 pm »
you need to create a pull request and one of us must accept it. When it has been accepted, the changes are copied to our repository.
Logged

opnsense_user12123

  • Guest
Re: [Template / Cicada] - short preview
« Reply #13 on: March 10, 2018, 07:33:15 pm »
.
« Last Edit: March 27, 2018, 05:07:19 pm by opnsense_user12123 »
Logged

opnsense_user12123

  • Guest
Re: [Template / Cicada] - short preview
« Reply #14 on: March 10, 2018, 08:03:13 pm »
Quote from: fabian on March 10, 2018, 07:29:17 pm
you need to create a pull request and one of us must accept it. When it has been accepted, the changes are copied to our repository.

i sent you a pm and i tried it again.
https://github.com/opnsense/plugins/pull/593

hope this is the right way!
Logged

  • Print
Pages: [1] 2 3 ... 5
« previous next »
  • OPNsense Forum »
  • English Forums »
  • Development and Code Review (Moderator: fabian) »
  • Cicada Theme -> Franco didnt want the cicada theme - so deleted!
 

OPNsense is an OSS project © Deciso B.V. 2015 - 2024 All rights reserved
  • SMF 2.0.19 | SMF © 2021, Simple Machines
    Privacy Policy
    | XHTML | RSS | WAP2