Cicada Theme -> Franco didnt want the cicada theme - so deleted!

Started by opnsense_user12123, March 07, 2018, 07:40:00 PM

Previous topic - Next topic
for anyone willing to test:

I made a test build which can be installed using:

pkg add https://files.fabian-franz.eu/os-Theme-Cicada-devel-0.1_1.txz

March 11, 2018, 03:43:55 PM #16 Last Edit: March 27, 2018, 05:07:38 PM by opnsense_user12123
.

March 11, 2018, 06:39:21 PM #17 Last Edit: March 27, 2018, 05:07:54 PM by opnsense_user12123
.

March 11, 2018, 08:28:48 PM #18 Last Edit: March 27, 2018, 05:08:44 PM by opnsense_user12123
.

March 24, 2018, 09:49:17 AM #19 Last Edit: March 27, 2018, 05:08:22 PM by opnsense_user12123
.

March 26, 2018, 12:07:53 PM #20 Last Edit: March 27, 2018, 05:08:33 PM by opnsense_user12123
.


In general, if code is submitted for inclusion we have to review it. People spend their free time to do so and all that is needed is patience and kindness. We try to minimise effort and want to create task forces for similar issues working towards a common goal. For anyone not being a team player this is an uphill battle because we will waste time arguing, blaming and give everyone directly involved the sensation of demotivation.

This incident cost time that could have been spent helping forum users and leaves a bad taste even though we've had a breakthrough in multi-wan + shaping in the kernel territory today.

Remember that it takes 5 good experiences to balance just a single bad one.

For reference:

https://github.com/opnsense/plugins/pull/592
https://github.com/opnsense/plugins/pull/593 -> review effort response https://github.com/opnsense/plugins/pull/593#issuecomment-372097687
https://github.com/opnsense/plugins/pull/595
https://github.com/opnsense/plugins/pull/597
https://github.com/opnsense/plugins/pull/598
https://github.com/opnsense/plugins/pull/599
https://github.com/opnsense/plugins/pull/625
https://github.com/opnsense/plugins/pull/626
https://github.com/opnsense/plugins/pull/629
https://github.com/opnsense/plugins/pull/632  -> second review effort https://github.com/opnsense/plugins/pull/632#issuecomment-376404747


Cheers,
Franco

I wont poke into the reasons why theme was not approved, personally I like it..its true, 2 dark themes make it redundant..but yours seams more polished and better looking ->  my personal opinion.

I wish it could make it to the official build. On your place I would not delete it as you did..leave it for people that will install it manually.

Thanks for your work.

Nothing was deleted. We've raised review concerns so they need to be discussed and agreed upon in some form. This is not a one-sided process. And we did not make any requests. Only questions were raised.

I'm happy to help again, but it needs to stay reasonable.


Cheers,
Franco

Quote from: Dimi3 on March 27, 2018, 05:42:30 PM
I wish it could make it to the official build. On your place I would not delete it as you did..leave it for people that will install it manually.
We cannot delete it (ok, I can delete the unofficial build from my server) from his repository. He decided to do that by himself. What franco did, was that he closed the pull request (as you can see in the history of the last ticket). Now the user deleted his GitHub account and with it the repository containing the theme.

Because it went that way (I helped a lot and lots of time lost for me too), I may remove the package from my server soon since there will not be any ongoing development. If you like it, you can download the file and keep it for your personal use at your own risk that it will break some day.

Well, I see you have deleted your account. But just in case you are reading this, know that there are, most of the times, reasons why something is not done the way you want it to be done, reasons which sometimes are complicated enough that you won't get a satisfactory answer. Although you might have found most answers in all the guides available for contributors.

Impulsively acting in such cases is never a good idea. Forcing your way into something is an even worse idea. This is not only true with OPNsense, but also generally in life. You will accumulate so many frustrations that one day you will burst into a ball of flames.

I do appreciate the work you have put into your theme, but in your case i think it was healthier for Franco to drop the theme than fighting you. It goes without saying that if you cannot deliver (which means deliver the way it must be done), it doesn't matter how valuable your work was, it is not a deliverable in the end.

I'm sure that if you would have given it some time, listen to what Franco suggested, I mean really listen, your theme would have made its way into OPNsense somehow, even in a form of a joint theme with the existing black theme.
OPNsense v18 | HW: Gigabyte Z370N-WIFI, i3-8100, 8GB RAM, 60GB SSD, | Controllers: 82575GB-quad, 82574, I221, I219-V | PPPoE: RDS Romania | Down: 980Mbit/s | Up: 500Mbit/s

Team Rebellion Member

Guys Im not taking sides here..I read the first post that the theme author deleted the theme and not make it available anymore, the part about deletion was not meant to opnsense team but to author of this post/theme.

At the end I like opnsense also in white :)...peace.

Frankly I don't care whether it's my dark theme his dark theme or someone else who does a  dark theme, just so long as there is a dark theme!

Yes, mine may not be as polished, but then it was done pretty quickly to get a dark theme!

I offered to help on Github once and got a flame of abuse from the OP, so that was it, I don't offer twice.

Anyway, how about a nice purple theme with lime green text... anyone?
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member

Why not one with blue and green tones while keeping the background white. ;)