OPNsense Forum

English Forums => Development and Code Review => Topic started by: opnsense_user12123 on March 07, 2018, 07:40:00 pm

Title: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: opnsense_user12123 on March 07, 2018, 07:40:00 pm
Because franco did not want two "dark themes". Even though both themes are totally different and he did not even test it, I have asked him to ask the community to decide which theme would be included as a new theme in the original repo of opnsense in the future.
But on my suggestion, he did not even enter, although I would have found this to be fair!

So unfortunately I have to delete the cicada theme.
So use the "dark theme" instead! ->Although it looks cheap but is created by a friend and profi of franco . thus the right decision for franco!

At the end 3 months of work for nothing and an imaginary programmer who destroys all my work.
Franco is a great admin and a person who knows how to motivate people.

I just want to warn everyone who volunteers to volunteer and invest time here.
It might be pretty conceited people here.
i´m back to PFSENSE !
Title: Re: Cicada Template short preview
Post by: opnsense_user12123 on March 08, 2018, 06:08:01 am
.
Title: Re: [Template / Cicada] - short preview
Post by: elektroinside on March 08, 2018, 07:09:32 am
This looks very nice! Great job!
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 08, 2018, 06:47:02 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 10, 2018, 12:31:22 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: fabian on March 10, 2018, 01:54:14 pm
I do not like this code - looks like really bad quality.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 10, 2018, 06:48:18 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: fabian on March 10, 2018, 07:06:36 pm
please feedback me!
Not your code, have not looked yet on it - the JS code for the calendar is bad.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 10, 2018, 07:07:21 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 10, 2018, 07:19:26 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: fabian on March 10, 2018, 07:22:39 pm

Isn't that correct?
https://github.com/opnsense/plugins/compare/master...opnsenseuser12123:master?expand=1 (https://github.com/opnsense/plugins/compare/master...opnsenseuser12123:master?expand=1)
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 10, 2018, 07:27:14 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: fabian on March 10, 2018, 07:29:17 pm
you need to create a pull request and one of us must accept it. When it has been accepted, the changes are copied to our repository.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 10, 2018, 07:33:15 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 10, 2018, 08:03:13 pm
you need to create a pull request and one of us must accept it. When it has been accepted, the changes are copied to our repository.

i sent you a pm and i tried it again.
https://github.com/opnsense/plugins/pull/593

hope this is the right way!
Title: Re: [Template / Cicada] - short preview
Post by: fabian on March 11, 2018, 02:16:26 pm
for anyone willing to test:

I made a test build which can be installed using:

pkg add https://files.fabian-franz.eu/os-Theme-Cicada-devel-0.1_1.txz
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 11, 2018, 03:43:55 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 11, 2018, 06:39:21 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 11, 2018, 08:28:48 pm
.
Title: Re: [Template / Cicada] - Theme orange/grey
Post by: opnsense_user12123 on March 24, 2018, 09:49:17 am
.
Title: Re: [Theme / Template / Cicada] - Orange/Grey
Post by: opnsense_user12123 on March 26, 2018, 12:07:53 pm
.
Title: Re: [Template / Cicada] - short preview
Post by: opnsense_user12123 on March 27, 2018, 03:57:29 pm
.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: franco on March 27, 2018, 05:33:09 pm
In general, if code is submitted for inclusion we have to review it. People spend their free time to do so and all that is needed is patience and kindness. We try to minimise effort and want to create task forces for similar issues working towards a common goal. For anyone not being a team player this is an uphill battle because we will waste time arguing, blaming and give everyone directly involved the sensation of demotivation.

This incident cost time that could have been spent helping forum users and leaves a bad taste even though we've had a breakthrough in multi-wan + shaping in the kernel territory today.

Remember that it takes 5 good experiences to balance just a single bad one.

For reference:

https://github.com/opnsense/plugins/pull/592
https://github.com/opnsense/plugins/pull/593 -> review effort response https://github.com/opnsense/plugins/pull/593#issuecomment-372097687
https://github.com/opnsense/plugins/pull/595
https://github.com/opnsense/plugins/pull/597
https://github.com/opnsense/plugins/pull/598
https://github.com/opnsense/plugins/pull/599
https://github.com/opnsense/plugins/pull/625
https://github.com/opnsense/plugins/pull/626
https://github.com/opnsense/plugins/pull/629
https://github.com/opnsense/plugins/pull/632  -> second review effort https://github.com/opnsense/plugins/pull/632#issuecomment-376404747


Cheers,
Franco
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: Dimi3 on March 27, 2018, 05:42:30 pm
I wont poke into the reasons why theme was not approved, personally I like it..its true, 2 dark themes make it redundant..but yours seams more polished and better looking ->  my personal opinion.

I wish it could make it to the official build. On your place I would not delete it as you did..leave it for people that will install it manually.

Thanks for your work.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: franco on March 27, 2018, 05:56:19 pm
Nothing was deleted. We've raised review concerns so they need to be discussed and agreed upon in some form. This is not a one-sided process. And we did not make any requests. Only questions were raised.

I'm happy to help again, but it needs to stay reasonable.


Cheers,
Franco
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: fabian on March 27, 2018, 06:05:07 pm
I wish it could make it to the official build. On your place I would not delete it as you did..leave it for people that will install it manually.
We cannot delete it (ok, I can delete the unofficial build from my server) from his repository. He decided to do that by himself. What franco did, was that he closed the pull request (as you can see in the history of the last ticket). Now the user deleted his GitHub account and with it the repository containing the theme.

Because it went that way (I helped a lot and lots of time lost for me too), I may remove the package from my server soon since there will not be any ongoing development. If you like it, you can download the file and keep it for your personal use at your own risk that it will break some day.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: elektroinside on March 27, 2018, 06:11:27 pm
Well, I see you have deleted your account. But just in case you are reading this, know that there are, most of the times, reasons why something is not done the way you want it to be done, reasons which sometimes are complicated enough that you won't get a satisfactory answer. Although you might have found most answers in all the guides available for contributors.

Impulsively acting in such cases is never a good idea. Forcing your way into something is an even worse idea. This is not only true with OPNsense, but also generally in life. You will accumulate so many frustrations that one day you will burst into a ball of flames.

I do appreciate the work you have put into your theme, but in your case i think it was healthier for Franco to drop the theme than fighting you. It goes without saying that if you cannot deliver (which means deliver the way it must be done), it doesn't matter how valuable your work was, it is not a deliverable in the end.

I'm sure that if you would have given it some time, listen to what Franco suggested, I mean really listen, your theme would have made its way into OPNsense somehow, even in a form of a joint theme with the existing black theme.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: Dimi3 on March 27, 2018, 06:12:24 pm
Guys Im not taking sides here..I read the first post that the theme author deleted the theme and not make it available anymore, the part about deletion was not meant to opnsense team but to author of this post/theme.

At the end I like opnsense also in white :)...peace.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on March 27, 2018, 07:49:53 pm
Frankly I don't care whether it's my dark theme his dark theme or someone else who does a  dark theme, just so long as there is a dark theme!

Yes, mine may not be as polished, but then it was done pretty quickly to get a dark theme!

I offered to help on Github once and got a flame of abuse from the OP, so that was it, I don't offer twice.

Anyway, how about a nice purple theme with lime green text... anyone?
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: fabian on March 27, 2018, 08:36:57 pm
Why not one with blue and green tones while keeping the background white. ;)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: weust on March 27, 2018, 08:41:09 pm
Any person deleting their account and editing every post they made replacing all content with a . is a sad puppy.
Will not miss that person at all.

@marjohn56 Pink and white Hello Kitty theme!
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on March 27, 2018, 08:46:55 pm
And you say they are sad puppies... ;D
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: weust on March 27, 2018, 08:51:17 pm
Puppies, not kitties ;-)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: elektroinside on March 27, 2018, 09:05:16 pm
I don't know guys.. is it worth it to label people (even if it's true)? :-)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on March 27, 2018, 09:12:48 pm
Yes, but only if it's true... 8)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: weust on March 27, 2018, 09:13:53 pm
I like puppies and kitties.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on March 27, 2018, 09:16:39 pm
I've got one on my lap. :)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: weust on March 27, 2018, 09:19:14 pm
My kitties are sleeping somewhere. They are older ladies.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: nivek1612 on March 27, 2018, 10:41:40 pm
How about a theme for us old boys that remember green screens

Oh how I miss my 3270 terminal :-)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: elektroinside on March 28, 2018, 06:31:13 am
 ;D ;D ;D
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: phoenix on March 28, 2018, 07:40:20 am
How about a theme for us old boys that remember green screens
I hope you mean black background with green text, I never had a green screen. :)

Oh how I miss my 3270 terminal :-)
You must be a youngster, the mainframes I worked with had IBM Selectric Typewriters as consoles when I started in the computer game.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on March 28, 2018, 10:11:01 am
I remember green screens... then again it could have been a flat CRT.  :)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: nivek1612 on March 28, 2018, 10:41:49 am
Quote
You must be a youngster, the mainframes I worked with had IBM Selectric Typewriters as consoles when I started in the computer game.

This feels like it could degenerate into the  Four Yorkshiremen sketch :-)

https://www.youtube.com/watch?v=VKHFZBUTA4k (https://www.youtube.com/watch?v=VKHFZBUTA4k)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on March 28, 2018, 03:15:04 pm
Yes, you were lucky to have a green screen....
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: phoenix on March 28, 2018, 04:43:14 pm
Quote
You must be a youngster, the mainframes I worked with had IBM Selectric Typewriters as consoles when I started in the computer game.

This feels like it could degenerate into the  Four Yorkshiremen sketch :-)
It certainly could except I'm a Lancashire lad myself (Liverpool, to be precise). :)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: dcol on March 28, 2018, 07:26:53 pm
or even better, I remember the amber screens on my Wang system. Still got one in storage.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: elektroinside on March 28, 2018, 08:00:44 pm
My oldest working setup is a 199x something Romanian made CIP computer:
http://www.old-computers.com/museum/computer.asp?c=700&

It needed a TV and cassettes for it to work :P I still have it, the unit itself, without the power supply, which I modified to build a controlled access system, based on public telephone cards :)) But it was built like a tank, I'm sure it still works :p
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: dcol on March 29, 2018, 04:36:31 pm
Now this is how to completely change the attitude of a thread.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: elektroinside on March 30, 2018, 06:24:26 am
Indeed. We should do this more often :-))
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: noname12123 on March 31, 2018, 09:33:34 am
Since the community can not help it, that I have stopped my work for opnsense, I like to make my work (the cicada template) available as a zip file.

https://bit.ly/2pTwWwZ

As far as I know, it's bug-free and it includes makefile, sass less the right structure, etc.

If you only want to use the template, simply move the cicada folder into the template folder of opnsense.

I hope to help at least a few community members to make their own template or opnsense to provide.

Whatever! I think, its the best theme opnsense has at the moment!

Thank you

P.S. I simply did not understand why it is so difficult to get a CSS template approved, especially if there is no real alternative and everyone could see from my commitment that I take my work very seriously. After all, this is not about PHP or any change in the database or ... a very simple CSS template. Well ..... should be like that.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: noname12123 on March 31, 2018, 12:44:51 pm
Yes, mine may not be as polished, but then it was done pretty quickly to get a dark theme!

I think that shows the best with which quality a template from the "PRO" is created here.
But his incredible work was approved.
-> You can not work together with someone like that seriously!

I've certainly made some mistakes, but for me the igoranz of my work (PR was never akzetiert) already provocation
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: franco on March 31, 2018, 12:51:14 pm
THIS is your FINAL warning before you will be banned:

Stop degrading the work of others.

You more than most people of this forum have received a tremendous amount of help from the community and you don't seem to be treating everyone with the respect they deserve.

This is not how open source works. It is how open source slowly dies.


Cheers,
Franco
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: Dimi3 on March 31, 2018, 10:07:07 pm
@noname12123, first you need to chill, if you want to work together with other people, this world is too fast already.

I would suggest you, since It happen to like your theme, to apologize for your actions, then work it out with franco. If theme is according to coding guidelines, there most probably should not be an issue for merge.

Pointing fingers to forum members will not be good.  You also need to understand developers priorities..themes are nice to have, but stability comes first.

I wish you, to find the way for your theme to make it to opnsense...but remember nice attitude is the way to go in life.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: elektroinside on March 31, 2018, 10:17:46 pm
@noname12123, first you need to chill, if you want to work together with other people, this world is too fast already.

I would suggest you, since It happen to like your theme, to apologize for your actions, then work it out with franco. If theme is according to coding guidelines, there most probably should not be an issue for merge.

Pointing fingers to forum members will not be good.  You also need to understand developers priorities..themes are nice to have, but stability comes first.

I wish you, to find the way for your theme to make it to opnsense...but remember nice attitude is the way to go in life.


Well said.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on April 01, 2018, 03:50:01 pm
Just a note to everyone, I have received an apology from noname123123 and I hope so has @franco, so lets give the guy some slack now. We all have lessons to learn in life and none of us are perfect, well most of you aren't  :P

I would ask the mod to delete this thread after a few days so we can close this chapter and move on. I'll be taking the Cicada theme under my wings and helping to get it pushed through.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: fabian on April 01, 2018, 05:36:55 pm
I would ask the mod to delete this thread after a few days so we can close this chapter and move on. I'll be taking the Cicada theme under my wings and helping to get it pushed through.

I prefer not to delete stuff because every deleted post is some loss of history. It does not change anything but what should be done is a lessons learned or similar as a final note.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: dcol on April 01, 2018, 06:36:12 pm
I agree. Close the thread but not a delete. We are better than that. hint hint
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: nivek1612 on April 02, 2018, 11:24:13 am
good to see its resolved
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: noname12123 on April 03, 2018, 08:47:04 am
Just a note to everyone, I have received an apology from noname123123 and I hope so has @franco, so lets give the guy some slack now. We all have lessons to learn in life and none of us are perfect, well most of you aren't  :P

I would ask the mod to delete this thread after a few days so we can close this chapter and move on. I'll be taking the Cicada theme under my wings and helping to get it pushed through.


Thank you again for your welcome. I just want to say that anyone who wants to improve the cicada theme can do it. color technology can be there a lot better. I'm also working on a new theme that is just the opposite of dark. will soon put a few screenshots of the new template then online here. thanks again for your support.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: elektroinside on April 03, 2018, 09:07:44 am
Welcome back! Looking forward to your new theme and productive cooperation :)
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: mimugmail on April 03, 2018, 09:17:07 am
Just a note to everyone, I have received an apology from noname123123 and I hope so has @franco, so lets give the guy some slack now. We all have lessons to learn in life and none of us are perfect, well most of you aren't  :P

I would ask the mod to delete this thread after a few days so we can close this chapter and move on. I'll be taking the Cicada theme under my wings and helping to get it pushed through.

Thank you again for your welcome. I just want to say that anyone who wants to improve the cicada theme can do it. color technology can be there a lot better. I'm also working on a new theme that is just the opposite of dark. will soon put a few screenshots of the new template then online here. thanks again for your support.

If you push Cicada again this will be the same old problems. Please consider in improving the existing dark theme. You'll collect some experiences how Github works and how to work in a team. It can and will be disappointing at some stage, but everyone contributing code in a project has to learn to live with it (so as I).

For a new theme there's no worries to create a new pull request, but please, do your first run with some small PR's to an existing theme. I can't count how many github mails I received from openend and closed PR's ;)

I invite you to join the IRC channel and I can give you a short introduction to Github (also in German).
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on April 03, 2018, 10:13:59 am
If you push Cicada again this will be the same old problems. Please consider in improving the existing dark theme. You'll collect some experiences how Github works and how to work in a team. It can and will be disappointing at some stage, but everyone contributing code in a project has to learn to live with it (so as I).

For a new theme there's no worries to create a new pull request, but please, do your first run with some small PR's to an existing theme. I can't count how many github mails I received from openend and closed PR's ;)

I invite you to join the IRC channel and I can give you a short introduction to Github (also in German).

I have taken this under my wing and have committed it this morning after testing it for a couple of days. There are sufficient differences between the two themes to have both. Yes, they are both dark, but Cicada uses different fonts and uses different colours in many places. I personally prefer Rebellion, others prefer Cicada.

For those wishing to try it, use the following method to install from the commit....once accepted.

# opnsense-code plugins
# cd /usr/plugins/misc/theme-cicada
# make upgrade
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: noname12123 on April 03, 2018, 07:54:42 pm
If you push Cicada again this will be the same old problems. Please consider in improving the existing dark theme. You'll collect some experiences how Github works and how to work in a team. It can and will be disappointing at some stage, but everyone contributing code in a project has to learn to live with it (so as I).

For a new theme there's no worries to create a new pull request, but please, do your first run with some small PR's to an existing theme. I can't count how many github mails I received from openend and closed PR's ;)

I invite you to join the IRC channel and I can give you a short introduction to Github (also in German).

I have taken this under my wing and have committed it this morning after testing it for a couple of days. There are sufficient differences between the two themes to have both. Yes, they are both dark, but Cicada uses different fonts and uses different colours in many places. I personally prefer Rebellion, others prefer Cicada.

For those wishing to try it, use the following method to install from the commit....once accepted.

# opnsense-code plugins
# cd /usr/plugins/misc/theme-cicada
# make upgrade

thx very much!

maybe there are a few things we can take over from the cicada theme to the dark theme!
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: marjohn56 on April 03, 2018, 07:57:41 pm
Let's leave them separate. As I said, they are sufficiently different to both exist. I prefer Rebellion, but it's personal taste.
Title: Re: Cicada Theme -> Franco didnt want the cicada theme - so deleted!
Post by: franco on April 04, 2018, 08:48:49 am
Thanks to everyone. For me the matter is resolved as well and we can move on.

I've asked noname12123 to take a little time to help shape the core theme issues as well as building the perfect theme in the plugins. The former helps everyone, helps to see how we communicate and review and improve so that the process for larger changes is more smooth for everyone involved.

Special thanks to Martin for helping noname12123 with the theme plugin inclusion.


Cheers,
Franco