dark theme first look

[marjohn56]

was that an rc install update or a clean 18.1?

if poss, can u do a quick fresh install of 18.1 to 18.1.1 install rebellion and see what you get?

[Evil_Sense]

was that an rc install update or a clean 18.1?

if poss, can u do a quick fresh install of 18.1 to 18.1.1 install rebellion and see what you get?

Was an rc install if I remember right, I can do that :)

[marjohn56]

Thanks muchly.

[Evil_Sense]

Thanks muchly.

Freshly installed 18.1 VM, updated to 18.1.1 and installed theme, still black text on cpu graph..

Edit:
I imported the configuration from the other VM, resettimg to factory defaults now and retrying..

[marjohn56]

This is daft :)

I'll look at after lunch and I'll do another fresh install.

[marjohn56]

ok... still works for me.

take a look at /usr/local/opnsense/www/themes/rebellion/build/css/nv.d3.css

Line 276 should be lightgrey

is it?

[Evil_Sense]

ok... still works for me.

take a look at /usr/local/opnsense/www/themes/rebellion/build/css/nv.d3.css

Line 276 should be lightgrey

is it?

It is indeed..

[franco]

Note that 18.1.1 does not have the theme-or-not file selector yet.

Once the plugin was installed manually, the firmware update will take care of updating it if a new version was published. Rerunning the commands will fetch the latest code from git and install it, too. Both work interchangeably, with the exception of the "make upgrade" forcefully upgrading it every time (but the latest version so that doesn't matter).

There is a slight complication when the theme is released as a stable version, although it won't matter much: there will be two packages, os-theme-rebellion and os-theme-rebellion-devel. Users of the development version can see and use both, mainly for staging reasons of larger changes the -devel version could differ... Users of the production release will only see os-theme-rebellion, but can use either version safely.

;D


Cheers,
Franco

[marjohn56]

OK, so why does mine show white text and not black and the same for pheonix? ???

[franco]

So who's on opnsense-devel (18.7.a_11) and who is on opnsense (18.1.1) ?

[marjohn56]

Ah... I switched to devel branch then back again to 18.1.1, that would explain things.  8)

[franco]

Not entirely, behaviour should be consistent as there is no wiggle-room for leaking the wrong css, unless the browsers tries to outsmart us.

[Evil_Sense]

Just took a look in the browser (vivaldi) with developer tools, fill isn't populated in .nvd3 text (adding it manually changes the color)
Same thing in firefox..

[Evil_Sense]

Installing the theme directly by "pgk install os-theme-rebellion-devel" results in white cpu usage text :)

[marjohn56]

Installing the theme directly by "pgk install os-theme-rebellion-devel" results in white cpu usage text :)

Ooerr...that's definitely one for Franco then.   :)