dark theme first look

[Evil_Sense]

Installing the theme directly by ”pgk install os-theme-rebellion-devel" results in white cpu usage text

Ooerr...that's definitely one for Franco then.   

Noticed it after reinstallation and also removed the theme on test vm to replace it with the mentioned command, the fill css property is now populated

[nivek1612]

after upgrading to 18.1.2_2 from 18.1.1_1 mine now white as well

No idea why but eh its working 

[temporal-agent]

I have installed it on 18.1.6, but nothing changes:

Code: [Select]

***GOT REQUEST TO INSTALL: os-theme-rebellion***
Updating OPNsense repository catalogue...
OPNsense repository is up to date.
All repositories are up to date.
Checking integrity... done (0 conflicting)
The following 1 package(s) will be affected (of 0 checked):

New packages to be INSTALLED:
os-theme-rebellion: 1.0

Number of packages to be installed: 1

The process will require 5 MiB more space.
[1/1] Installing os-theme-rebellion-1.0...
[1/1] Extracting os-theme-rebellion-1.0: .......... done
Checking integrity... done (0 conflicting)
Nothing to do.
***DONE***
is there something i need to change or configure?

[marjohn56]

Have you selected the theme in System->Settings->General ?

[temporal-agent]

Have you selected the theme in System->Settings->General ?

No... I couldn't find it.  But now it works, thanks.

[qinohe]

Thanks for rebellion really like this dark theme.
I have a request: can the background for 'OTP QR code' found on the users page be made a color scanable by phones?
If I want to scan a new QR code I first have change to the default theme, scan the QR code, change back to rebellion.

Thanks mark

[marjohn56]

I'll see what I can do. It may require the QR image to have a white border around it.

[qinohe]

Thanks for your reply marjohn56 very kind of you to look into it.
It may be so yes, I have done a little research and found a pdf saying just that, it's called 'Quiet Zone' see 7.3 on  https://web.archive.org/web/20110812190511/http://raidenii.net/files/datasheets/misc/qr_code.pdf

[marjohn56]

I'll put a shout out for @franco to look at this thread, not sure who authored that bit of code.


I've raised an issue for this on Gihub  #2430

[qinohe]

Oh well it's done with the best of intentions I guess and if there would not have been a dark theme in the first place no one would have noticed anyway 

[marjohn56]

This is true... 


I suspect it isn't a major problem and I could go hunt for it and probably fix it, but the original author will know where to look straight away.

[qinohe]

No stress until then I'm okay the way it is 
But I dug a little deeper into that pfd, section 10.1 dimensions says:
minimum quiet zone:   equal to 4X on all four sides
Not knowing exactly how big that is, but it's a starter, you should probably read it yourself as there is more to it.

[marjohn56]

Yes, I read it before I raised the issue on Github... It'll be fixed before you know it.

[marjohn56]

It's fixed, will be pulled into a release shortly, thanks to Ad for fixing it so quickly.

https://github.com/opnsense/core/issues/2430


What's that then, less than twelve hours from report to fix, and that includes sleep time too.


Opnsense is good isn't it. 

[franco]

Or patch directly from the console, but don't forget to clear the browser cache.

# opnsense-patch 2f247f2

also see

https://github.com/opnsense/core/commit/2f247f2


Cheers,
Franco