dark theme first look

[franco]

Several PRs later, the change has been landed. :)

[marjohn56]

Yes Yes... Github confuses me. Especially at daft o'clock when I should be asleep.  :P

[marjohn56]

Update PR just issued. Fixes CPU tooltip issue and many others. Need feedback on this as there were a LOT of corrections.

Just wait for Franco to do his bit...

[elektroinside]

I'm already using it  ;D

Thank you for your work!

[fabian]

Moved the topic to this section as it fits better to "Development and Code Review". New Plugins should be discussed here because "General Discussion" is for discussing network setups, configuration etc. while this section is for discussing new features, code, and new plugins.

[franco]

One thing I need to mention is that SCSS should be updated as well and CSS compiled from it, it could create a nightmare later on if that's not done prior to a real release when the original theme changes and requires updates to the dark theme...



Cheers,
Franco

[marjohn56]

OK, I have re-done the whole thing but this time used the scss and less files and then compiled them to create the new theme. I'll issue a PR shortly and see what you think.

[franco]

Yay, thanks. I'm wrapping up plugins for 18.1 today so we can get that into the 18.1 build as a development package. \o/

[marjohn56]

Still some oddities there, but I'll issue fixes as I find and resolve them.

[marjohn56]

With a bit of a push here and there I've fixed all of the external theme issues except the gateways status bits. The fixes may not make it to 18.1 as they involve moving most of the existing *.css files to the  opnsense theme folder and altering a couple of files to correct the paths. As a result it needs to be thoroughly checked before I can issue a   PR.

Looking good though.

[weust]

Very nice.

With the changes you need to make, does that help the default theme too?

[marjohn56]

What's broken in the default theme? ( Apart from the colour scheme :P )

[elektroinside]

It looks awesome! I like it a lot!

[weust]

What's broken in the default theme? ( Apart from the colour scheme :P )

Maybe I understood it wrong, but didn't you change/move parts of the theme files to places where they actually should be? And shouldn't the default theme be modified in that way too?
That's what I mean with helping the default theme too.

[marjohn56]

I have, but that has not made it through yet.

You are correct in that there is an issue with some of the CSS files in that they live outside of the themes folder. The PR I have issued in core resolves that and so both rebellion and opnsense themes work properly. I think Franco is waiting for Ad to take a look at it - as whilst working in that area there are other bits that could do with changing.