OPNsense
  • Home
  • Help
  • Search
  • Login
  • Register

  • OPNsense Forum »
  • English Forums »
  • Development and Code Review (Moderator: fabian) »
  • dark theme first look
« previous next »
  • Print
Pages: 1 2 [3] 4 5 ... 7

Author Topic: dark theme first look  (Read 54698 times)

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 17660
  • Karma: 1611
    • View Profile
Re: dark theme first look
« Reply #30 on: January 19, 2018, 09:25:03 am »
Several PRs later, the change has been landed. :)
Logged

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: dark theme first look
« Reply #31 on: January 19, 2018, 09:29:59 am »
Yes Yes... Github confuses me. Especially at daft o'clock when I should be asleep.  :P
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: dark theme first look
« Reply #32 on: January 20, 2018, 10:23:58 am »
Update PR just issued. Fixes CPU tooltip issue and many others. Need feedback on this as there were a LOT of corrections.

Just wait for Franco to do his bit...
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

elektroinside

  • Hero Member
  • *****
  • Posts: 574
  • Karma: 51
    • View Profile
Re: dark theme first look
« Reply #33 on: January 20, 2018, 11:48:29 am »
I'm already using it  ;D

Thank you for your work!
Logged
OPNsense v18 | HW: Gigabyte Z370N-WIFI, i3-8100, 8GB RAM, 60GB SSD, | Controllers: 82575GB-quad, 82574, I221, I219-V | PPPoE: RDS Romania | Down: 980Mbit/s | Up: 500Mbit/s

Team Rebellion Member

fabian

  • Moderator
  • Hero Member
  • *****
  • Posts: 2769
  • Karma: 200
  • OPNsense Contributor (Language, VPN, Proxy, etc.)
    • View Profile
    • Personal Homepage
Re: dark theme first look
« Reply #34 on: January 20, 2018, 12:05:14 pm »
Moved the topic to this section as it fits better to "Development and Code Review". New Plugins should be discussed here because "General Discussion" is for discussing network setups, configuration etc. while this section is for discussing new features, code, and new plugins.
Logged

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 17660
  • Karma: 1611
    • View Profile
Re: dark theme first look
« Reply #35 on: January 20, 2018, 02:26:10 pm »
One thing I need to mention is that SCSS should be updated as well and CSS compiled from it, it could create a nightmare later on if that's not done prior to a real release when the original theme changes and requires updates to the dark theme...



Cheers,
Franco
Logged

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: dark theme first look
« Reply #36 on: January 21, 2018, 01:34:49 pm »
OK, I have re-done the whole thing but this time used the scss and less files and then compiled them to create the new theme. I'll issue a PR shortly and see what you think.
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 17660
  • Karma: 1611
    • View Profile
Re: dark theme first look
« Reply #37 on: January 21, 2018, 01:39:17 pm »
Yay, thanks. I'm wrapping up plugins for 18.1 today so we can get that into the 18.1 build as a development package. \o/
Logged

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: dark theme first look
« Reply #38 on: January 21, 2018, 04:26:34 pm »
Still some oddities there, but I'll issue fixes as I find and resolve them.
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: dark theme first look
« Reply #39 on: January 22, 2018, 04:13:31 pm »
With a bit of a push here and there I've fixed all of the external theme issues except the gateways status bits. The fixes may not make it to 18.1 as they involve moving most of the existing *.css files to the  opnsense theme folder and altering a couple of files to correct the paths. As a result it needs to be thoroughly checked before I can issue a   PR.

Looking good though.
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

weust

  • Hero Member
  • *****
  • Posts: 650
  • Karma: 57
    • View Profile
Re: dark theme first look
« Reply #40 on: January 22, 2018, 05:36:29 pm »
Very nice.

With the changes you need to make, does that help the default theme too?
Logged
Hobbyist at home, sysadmin at work. Sometimes the first is mixed with the second.

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: dark theme first look
« Reply #41 on: January 22, 2018, 07:17:38 pm »
What's broken in the default theme? ( Apart from the colour scheme :P )
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

elektroinside

  • Hero Member
  • *****
  • Posts: 574
  • Karma: 51
    • View Profile
Re: dark theme first look
« Reply #42 on: January 23, 2018, 09:16:24 am »
It looks awesome! I like it a lot!
Logged
OPNsense v18 | HW: Gigabyte Z370N-WIFI, i3-8100, 8GB RAM, 60GB SSD, | Controllers: 82575GB-quad, 82574, I221, I219-V | PPPoE: RDS Romania | Down: 980Mbit/s | Up: 500Mbit/s

Team Rebellion Member

weust

  • Hero Member
  • *****
  • Posts: 650
  • Karma: 57
    • View Profile
Re: dark theme first look
« Reply #43 on: January 23, 2018, 09:25:10 am »
Quote from: marjohn56 on January 22, 2018, 07:17:38 pm
What's broken in the default theme? ( Apart from the colour scheme :P )

Maybe I understood it wrong, but didn't you change/move parts of the theme files to places where they actually should be? And shouldn't the default theme be modified in that way too?
That's what I mean with helping the default theme too.
Logged
Hobbyist at home, sysadmin at work. Sometimes the first is mixed with the second.

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: dark theme first look
« Reply #44 on: January 23, 2018, 09:29:53 am »
I have, but that has not made it through yet.

You are correct in that there is an issue with some of the CSS files in that they live outside of the themes folder. The PR I have issued in core resolves that and so both rebellion and opnsense themes work properly. I think Franco is waiting for Ad to take a look at it - as whilst working in that area there are other bits that could do with changing.
« Last Edit: January 23, 2018, 09:35:39 am by marjohn56 »
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud
  • Print
Pages: 1 2 [3] 4 5 ... 7
« previous next »
  • OPNsense Forum »
  • English Forums »
  • Development and Code Review (Moderator: fabian) »
  • dark theme first look
 

OPNsense is an OSS project © Deciso B.V. 2015 - 2024 All rights reserved
  • SMF 2.0.19 | SMF © 2021, Simple Machines
    Privacy Policy     | XHTML | RSS | WAP2