lots of empty space in new firewall ui, yet I must scroll

[bimbar]

I know you're helping Patrick but it doesn't make things easier here. This is the first post:

Maybe we can get rid of the scrolling subframe? Or at least scale the frame to the full height that is available?

On my screen the firewall rules window uses about half of the available height, but I can scroll way down

This is the commit in 26.1.6:

https://github.com/opnsense/core/commit/0e999cc5a

OP asked for it but did not acknowledge its existence.

One of the reasons we ask for actionable tickets is so the requester can confirm that is what they wanted (or not).

Everybody else adding related context in this forum thread doesn't help progress the initial request anymore.


Cheers,
Franco

Yes, I did not catch that. It is true that this particular bug is fixed, thank you.

Still, the general problem of poor space usage remains. So I completely agree with Patrick on that matter.

[Patrick M. Hausen]

I think you have uploaded the wrong screenshot ?!

Fixed in the post - thank you.

[franco]

Yes, I did not catch that. It is true that this particular bug is fixed, thank you.

Thanks for confirming.

[nero355]

I am sorry for bringing this topic up again, but I have no choice : The amount of data I can see in the webGUI part of Firewall Rules [New] is A LOT LESS than the old Firewall Rules that will become Legacy starting with 26.7 and moved to a plug-in :'(

Here are some screenshots :

Firefox - 1366x768 Laptop Screen


LibreWolf - 1366x768 Laptop Screen


Pale Moon - 1366x768 Laptop Screen


Pale Moon - 1920x1200 Desktop Monitor - Windowed


Pale Moon - 1920x1200 Desktop Monitor - Window resized to almost the size of the whole monitor



Issues I have with the Firewall Rules [New] webGUI :
- I can't see all the rules like I could in the old Firewall Rules and can't even scroll to see more on a 1366x768 screen.
- I feel like the 'Commands' should be part of the whole Firewall Rule line and not a side-menu or overlay sub-window so to speak.
This forces you to scroll sideways to be able to see the 'Comment' part of the Firewall Rule for example.
- On the 'Pale Moon - 1920x1200 Desktop Monitor - Windowed' screenshot you can see that there is a lot of overlapping of text and everything is not outlined if you know what I mean.
This is also the case for 'Pale Moon - 1366x768 Laptop Screen' and in the case of 'Pale Moon - 1920x1200 Desktop Monitor - Window resized to almost the size of the whole monitor' this leads to a lot of added unnecessary space and waste of it.
- Even on the 'Pale Moon - 1920x1200 Desktop Monitor - Window resized to almost the size of the whole monitor' screenshot you can see that I can't see all the Firewall Rules which is just strange : Both how much width the data needs and how much data is shown from top to bottom.


I would kindly like to ask you guys to have another look at this and maybe redesign it a bit ? :)



/EDIT :
Maybe I should have posted this in another topic : https://forum.opnsense.org/index.php?topic=51158.0 ?!
I remembered there was a second topic, but thought they were almost the same, however that does not seem to be the case...

[franco]

> I can't see all the rules like I could in the old Firewall Rules and can't even scroll to see more on a 1366x768 screen.

Are you using a different zoom on the laptop browsers? In 100% on HD resolution I see more than you. 90% seems to be a good tradeoff in terms of usability.

> - I feel like the 'Commands' should be part of the whole Firewall Rule line and not a side-menu or overlay sub-window so to speak.
This forces you to scroll sideways to be able to see the 'Comment' part of the Firewall Rule for example.

Yes we are aware on constrained screens. Cedrik already has a POC.

> - On the 'Pale Moon - 1920x1200 Desktop Monitor - Windowed' screenshot you can see that there is a lot of overlapping of text and everything is not outlined if you know what I mean.
This is also the case for 'Pale Moon - 1366x768 Laptop Screen' and in the case of 'Pale Moon - 1920x1200 Desktop Monitor - Window resized to almost the size of the whole monitor' this leads to a lot of added unnecessary space and waste of it.

The overlapping text seems to be somewhat local issue at first glance. My text breaks naturally over here and on your laptop too. While space can be improved I see 18 rows rendered which is half the screen. I feel like people bring up this argument now more than ever but the overall page layout hasn't changed since 2015. I'm just unsure what people are asking in the grand scheme of things.

> - Even on the 'Pale Moon - 1920x1200 Desktop Monitor - Window resized to almost the size of the whole monitor' screenshot you can see that I can't see all the Firewall Rules which is just strange : Both how much width the data needs and how much data is shown from top to bottom.

Not sure I understand. Looking at the legacy one I don't see the immediate difference. The one thing the legacy GUI does differently is hide columns when space is too sparse. Command buttons behave the same actually and you can remove individual columns to read it better.


Cheers,
Franco


PS: thuis.lan is grappig ;)

[nero355]

Are you using a different zoom on the laptop browsers?

No scaling or zoom active : Everything is 1:1 pixelmapped so to speak.

In 100% on HD resolution I see more than you. 90% seems to be a good tradeoff in terms of usability.

Hmm... weird... because this bugs me everywhere when Tabulator is involved basically...

I will do some testing and upload more screenshots :)

Yes we are aware on constrained screens. Cedrik already has a POC.

I meant in general. Not just on small screens.

Somehow it "feels more natural" if you know what I mean...

The overlapping text seems to be somewhat local issue at first glance.

As in browser issue ?

My text breaks naturally over here and on your laptop too.

Not sure what you mean. I would expect Destination and Port not to overlap ?

While space can be improved.

When that is done perhaps the overlapping will be fixed too ?

I see 18 rows rendered which is half the screen.

Sorry, but I feel like there should be more visible like in the old Firewall Rules webGUI : Just extend the thing all the way to the bottom and let my browser scroll it like Patrick mentioned a couple of times :)

I feel like people bring up this argument now more than ever but the overall page layout hasn't changed since 2015.
I'm just unsure what people are asking in the grand scheme of things.

I think we all want to "escape the Tabulator confinement" because we all feel a bit claustrophobic :)

Not sure I understand. Looking at the legacy one I don't see the immediate difference. The one thing the legacy GUI does differently is hide columns when space is too sparse. Command buttons behave the same actually and you can remove individual columns to read it better.

I will do some comparisons and see what happens and take screenshots again if needed.

Did not know about the column hiding feature so that might change things indeed!

PS: thuis.lan is grappig ;)

Thnx! ^_^

I needed a domain 10+ years ago for Pi-Hole and that seemed somehow the least conflicting with official standards option... LOL!

[nero355]

PART #2 of the story above after additional testing :

In 100% on HD resolution I see more than you.
90% seems to be a good tradeoff in terms of usability.

At 1366x768 it seems that I need 70% to 60% Zoom Out to get a decent view, but since 60% is a bit extreme for the eyes it looks like 70% is the better choice.

I feel like people bring up this argument now more than ever but the overall page layout hasn't changed since 2015.
I'm just unsure what people are asking in the grand scheme of things.

After another look it seems that :
- Firewall Rules [New] shows more compacted data and uses the height better than the old Firewall Rules.
But...
- The old Firewall Rules uses the width better and can be simply scrolled until the bottom of the complete browser window!

Screenshot to show the difference :


But the "Final Result" is : The old Firewall Rules shows more data!

Looking at the legacy one I don't see the immediate difference.

I have done some "How much screenspace do I need to see what I want to see ?" measurements after optimizing the view for both the old Firewall Rules and Firewall Rules [New] :

The old Firewall Rules - Window needs to be 1574x1170 :


Firewall Rules New - Window needs to be 1714x1170 :


But again also here the "Final Result" is : The old Firewall Rules shows more data!


And last, but not least =>

Firewall Rules New - Window needs to be 1932x1170 to SEE ALL DATA


That's wider than a regular 1920x1080 or 1920x1200 display...

It was also very tricky to accomplish because of the resizing of each column that needed to be done after resizing the window to avoid wasted screenspace after each adjustment.


FINAL CONCLUSION =>

I think it's safe to say that if :
- The 'Commands' column did not overlap.
- The 'Commands' were part of each Firewall Rules line.
- All columns are always optimized and only use the width that's actually needed.
- The bottom of the Firewall Rules [New] was not cut off by Tabulator.
(And the width too then I guess ?!)

The amount of data shown by Firewall Rules [New] would be simply PERFECT! :)

Does anyone agree with me ??

The one thing the legacy GUI does differently is hide columns when space is too sparse.

After some testing that seems to be more a thing when you Zoom In at values that don't make any sense when is comes to the useability so we can ignore that feature :)

you can remove individual columns to read it better.

As far as I can see that's only the case for Firewall Rules [New] and not the old Firewall Rules ?



Also something (possibly) strange I have noticed :
By default there is a column called 'Statistics' activated but is not shown for some reason ?

Could that reason be that I have a lot of Statistics and Logging DISABLED and that automatically hides it ?

[Monviech (Cedrik)]

The statistics column unhides when you press the Inspect button to show rule statistics.

My normal screen has 5120x2160. I can have two complete rule windows open side by side xD

Overprovisioning is a fix everywhere lol.