running a ZFS vDisk on a ZFS Proxmox OS is useless and redundant. Is this not the case?
Correct, ZFS on ZFS does not excatly help with performance, but OpnSense does not need disk performance and having an indestructible filesystem like ZFS is a plus - as you can see here.Using something like cv4pve-autosnap prevents you from ever coming into the situation where you think: Damn, I wish I had done a snapshot before this. And it comes cheap if Proxmox is running on ZFS.
[...] but you can use "discard" for the VM disk to reuse those free blocks.
Correct. The trim command is used to discard the blocks. Under Proxmox, you can even enable SSD emulation.BTW: If /dev/vtbdp03 is only 7.1 of 54 GByte, the maybe it was not logging that caused the problem. But I do not know which partitions are used under UFS, so do not know it that one holds the log data.