[CALL FOR TESTING] PPPoE restructuring and IPv6 improvements

[doktornotor]

But I saw there something strange:
It seems that after applying the patch, an additional Gateway appeared.
Background:
To access my DSL modem I configured the interface of the PPPoE connection additionally with a static IP (see attachments).

No extra gateway here with same config. With the patch applied, everything works as before.

[franco]

Thanks for the input. Sounds pretty good. Would like to ship this in 24.7.2 with the feedback we have now but in terms of being careful it's probably better to do 24.7.3 for this particular patch. The next iteration will be a bit more invasive in terms of when PPP is started and stopped, but it should also not cause any change in observed behaviour (unless there is a bug we need to catch).


Cheers,
Franco

[computeralex92]

Thanks a lot testing my strange "behavior".
I removed the patch again and after a reboot, the additional gateway disappeared.

Maybe it is a side effect of having multiple patches active at the same time; I removed them now all:

Code: [Select]

287c13beb8e interfaces: avoid touching SLAAC address for now
9ddd363bdbb firmware: add upgrade hint to 24.7 crossing ABI
3a9f98843b0 interfaces: move IPv6 connectivity to a separate s

[doktornotor]

Code: [Select]

287c13beb8e interfaces: avoid touching SLAAC address for now

Hmmm, but this is not intended for 24.7.1, will apply reversed (i.e., undo the included patch to 24.7 state)¨

[MikeH]

A bit late to the party, but I can confirm everything works as before here.
What I've done:
- opnsense-patch
- reboot my box
- reboot my main switch, to assure all devices get new DHCP leases (not necessary, but I upgraded the firmware and took the opportunity --> rebooting the main switch takes down the whole network as the second switch and APs are PoE powered)

My setup (G.fast line)
- Bare metal, WAN port is a dedicated interface. No VLAN, DHCP option or anything on WAN. OPNsense 24.7.1
- IPv4: PPPoE
- IPv6: DHCP6, getting a /48
- In WAN setup -> PPPoE configuration "Use IPv4 connectivity" is marked and prefix size is set to 48, everything else is default.

Everything works. IPv4 only sites, IPv6 only sites, no additional gateway, no speed decrease or anything.

[Patrick M. Hausen]

Applied, rebooted, all well with German Telekom business DSL line.

I never used "track interface", though. All static internally.

[planetf1]

Tried out the patch & rebooted(pppoe, ipv6 dual stack, /48 prefix dynamically retrieved) - all seems to work fine

[PhoenixRider]

I also have applied the patch on my OPNsense and everything is fine. I left activated the IPv6-Feature "Request only prefix" (because many VLANs), meaning i didn't make any changes.

[teg]

I'm using Opnsense with a Freedom Internet FttH connection in The Netherlands. It seems to work like before.

[franco]

Thanks all! We can more or less wrap this first batch up. Let's wait for 24.7.3 to hit and we'll see about that second batch.


Cheers,
Franco

[Balogh]

Applied patch. Did NOT reboot. Disabled WAN IF, saved, applied. Enabled WAN IF, saved, applied.
All fine, inluding IPv6 /56 prefix.
ISP: Digi Romania.

[franco]

Thank you

Might just hand out the second patch sooner (i.e. later today). Feeling lucky.


Cheers,
Franco

[thecrankygamer]

Will this restructure improve speeds (work around 1core issue)

[franco]

Nope.

[franco]

While we wait for our traceroute situation to get better here's the second PPPoE patch:

https://github.com/opnsense/core/commit/3a9f98843b <-- old patch foundation
https://github.com/opnsense/core/commit/182bab339a <-- new patch on top


# opnsense-revert opnsense && opnsense-patch 3a9f98843b 182bab339a

With the second patch, the decision to start and stop mpd5 is no longer directly tied to the IPv4 and IPv6 mode set up in the interface, but the whole thing should still be 100% compatible.


Cheers,
Franco