[SOLVED] 23.7.8 - No Label in Live View

Started by tillsense, November 09, 2023, 05:28:35 PM

Previous topic - Next topic
November 09, 2023, 05:28:35 PM Last Edit: November 10, 2023, 09:02:49 AM by franco
Hi,
the label is no longer displayed in the Firewall live view.

cheers
tillsense


November 09, 2023, 05:56:59 PM #2 Last Edit: November 09, 2023, 05:59:30 PM by block109
Hi
I'm seeing the same thing here
+1

Yes, it's a faulty stable commit to the FreeBSD base system. I'll rebuild and replace the kernel once confirmed fixed.


Cheers,
Franco

I reverted this commit https://github.com/opnsense/src/commit/8c97958ae1a originating from the FreeBSD stable/13 branch and replaced the base set on the main mirror.

If you run into this issue reinstall the base set from System: Firmware: Packages. It requires a reboot but brings back the proper label handling.

I don't want to complain, but this is comes from a familiar source not know for it's impeccable sponsorships in the area... My fault for merging it though. The question is if anybody else would have noticed soon or if this would go into FreeBSD 13.3 undetected.


Cheers,
Franco

Might as well post the instructions posted elsewhere already:

If you are having trouble on 23.7.8 with the live log labels missing and/or the firewall widget being empty please reinstall 23.7.8 "base" set from System: Firmware: Packages. A reboot is required but brings the functionality back.

Here is my take on the actual issue and how existing QA and release process appears to have failed:

https://github.com/opnsense/src/commit/cc48f7c1551

From the commit:

This code was supposed to apply to pfctl_add_eth_rule() but instead
applied to pfctl_add_rule() for otherwise interesting reasons.  Since
pfctl_add_eth_rule() uses "nvl" and pfctl_add_rule() uses "nvlr" but
also has "nvl" this compiled fine but still broke the label set.

The bit that is most intriguing is that pfctl_add_eth_rule() doesn't
even exist on stable/13 and that this wasn't caught by the existing
tests.


Cheers,
Franco

I re-installed base package multiple times now. But the widget is still empty.

Had the same problem with empty widget after base reinstall. It started to populate entries in the widget the next day. Don't know if there is any log rotation involved but maybe leave it alone for now and check back tomorrow if it finally works.

Hi franco,

base has been reinstalled and the labels are back. thanks for the quick response (and solved :) but i was away..thanks!

cheers
till

Quote from: xavx on November 10, 2023, 07:18:56 PM
Had the same problem with empty widget after base reinstall. It started to populate entries in the widget the next day. Don't know if there is any log rotation involved but maybe leave it alone for now and check back tomorrow if it finally works.

It sounds like some people confuse the "widget empty" with the JavaScript freeze the widget encountered when trying to read labels not being supplied by the kernel because setting the labels in the rule configuration failed and the kernel never got them.

You should check if the live view gives you entries with labels. If it doesn't give you labels you have the wrong base build. If you don't have any entries in the live log your rule logging is set too low or off or a filter applies. If you see the labels and logs in the live view without a filter also check if your firewall widget filters for something else... because if the firewall live log works and the labels are there your firewall widget works too because it's the same source of the firewall logs.


Cheers,
Franco

I have new entries in Live Log with labels. But the widget is still empty if I select "Interfaces to display: ALL". If I select "wan" or something else I have entries. Just "all" is empty.

November 10, 2023, 11:04:32 PM #12 Last Edit: November 10, 2023, 11:30:03 PM by xavx
Still having weird thing maybe related. The tab "ui/diagnostics/firewall/pf_top" shows Rule = null for all entries.
"ui/diagnostics/firewall/states" shows the rules properly.
Just did a reinstall of base to be sure and still the same. Is that expected or not ?

November 11, 2023, 10:37:52 AM #13 Last Edit: November 12, 2023, 08:48:13 AM by doktornotor
Quote from: xavx on November 10, 2023, 11:04:32 PM
Still having weird thing maybe related. The tab "ui/diagnostics/firewall/pf_top" shows Rule = null for all entries.

Confirmed. https://github.com/opnsense/ports/issues/182

Hi,

i can confirm that too. there seems to be more broken here?

cheers
till