Plugin warnings for Gateway status

[4r7ur]

Good morning,

after updating to day to 22.7.10_2-amd64 (FreeBSD 13.1-RELEASE-p5/OpenSSL 1.1.1s 1 Nov 2022) I receive about every 5 seconds or so a lot of warnings like this:

2022-12-22T10:27:36
opnsense   /usr/local/opnsense/scripts/routes/gateway_status.php: plugins_run return_gateways_status (execute task : dpinger_status())
2022-12-22T10:27:36
opnsense   /usr/local/opnsense/scripts/routes/gateway_status.php: plugins_run return_gateways_status ()
2022-12-22T10:27:31
opnsense   /usr/local/opnsense/scripts/routes/gateway_status.php: plugins_run return_gateways_status (execute task : dpinger_status())
2022-12-22T10:27:31
opnsense   /usr/local/opnsense/scripts/routes/gateway_status.php: plugins_run return_gateways_status ()

I'm not sure if this was already an issue before the 22.7.10_2 hotfix. If I remove the gateways widget from the dashboard, the warings stop. Any idea how to supress these messages?

Kind regards,
Artur

[FullyBorked]

Not sure the fix, but I'm seeing these logs too. 

[danderson]

same as above, seeing the errors in 22.7.10_2

[NW4FUN]

Same here

[dcol]

I have them too. But they are not errors, just Notices. Probably can be ignored

[franco]

Where was the log output copied from? It's not a "warning" either, not by syslog priority nor by content.

It's about https://github.com/opnsense/core/commit/b493c543039d but the message was always there as a debug message. Since it didn't go into the log because the minimum level is notice it now goes into the log by magic of log_msg().

I'm not convinced the log messages in plugins.inc hold any value, but so far it was discussed to keep them and make them visible.


Cheers,
Franco

[FullyBorked]

Where was the log output copied from? It's not a "warning" either, not by syslog priority nor by content.

It's about https://github.com/opnsense/core/commit/b493c543039d but the message was always there as a debug message. Since it didn't go into the log because the minimum level is notice it now goes into the log by magic of log_msg().

I'm not convinced the log messages in plugins.inc hold any value, but so far it was discussed to keep them and make them visible.



Cheers,
Franco

I see then in System > Logfile > General.  Yes they are labeled as notice not warning.  I hadn't seen them before, is the reason I posted.   

Edit: I use the syslog widget to get a quick view of the log file to see if anything is there I should take notice of, this log spam fills up that widget so any useful log is pushed off quickly.  Otherwise it seems harmless.

[franco]

The commit can very likely be reverted with the patch:

 # opnsense-patch b493c543039d

I'm not sure what we will do but I can bring it up for when we start planning for 22.7.11.


Cheers,
Franco

[FullyBorked]

The commit can very likely be reverted with the patch:

 # opnsense-patch b493c543039d

I'm not sure what we will do but I can bring it up for when we start planning for 22.7.11.


Cheers,
Franco

Personally for me it's not that big of a deal.  Might look into filtering that widget though.  It has a filter option but I'm not sure how it works.  I'll mess with that and see if I can filter by log level. 

[ColeTrain]

still gettin em

[franco]

I'll bring up the topic in our final 23.1 talk on Monday. But keep in mind this is purely cosmetic (and yes nothing changed so everything is still as it was).


Cheers,
Franco

[Fright]

@FullyBorked
can you test log widget with the

Code: [Select]

opnsense-patch -a kulikov-a 626651eapplied, please?
(https://github.com/kulikov-a/core/commit/626651e)
widget was refactored before the RFC5424 migration and i would be happy to add an severity filter if @franco doesn't mind )

[franco]

Spurious logging from plugins_run() will be removed in 23.1: https://github.com/opnsense/core/commit/7248a47143f


Cheers,
Franco

[FullyBorked]

@FullyBorked
can you test log widget with the

Code: [Select]

opnsense-patch -a kulikov-a 626651eapplied, please?
(https://github.com/kulikov-a/core/commit/626651e)
widget was refactored before the RFC5424 migration and i would be happy to add an severity filter if @franco doesn't mind )

I installed it but doesn't look like I can see any option other than debug.  See attached screenshot.

[Fright]

oops. I'm sorry, I completely forgot that I'm testing on a "gridstack.js" lobby..
opnsense-patch -a kulikov-a 7ea01a3
(don't revert previous)
(https://github.com/kulikov-a/core/commit/7ea01a3)
shoud make this work
sorry