dynDNS does not work after upgrade

Started by SoGX, July 17, 2019, 05:01:46 PM

Previous topic - Next topic
July 17, 2019, 05:01:46 PM Last Edit: July 18, 2019, 02:19:28 AM by SoGX
Hello erverybody,

after Upgrading from 19.1.10 to 19.70 dynDNS isn't working anymore.

[17-Jul-2019 17:00:17 Europe/Berlin] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc on line 758

Did anyone have the same bug after an upgrade and have already fixed it?


Hi,

We turned warnings for PHP back on in 19.7. Are you sure there is a bug that goes along with this or are you assuming it is buggy now?

The warning by itself shouldn't be problematic and will be fixed in 19.7.1 for sure.


Cheers,
Franco

Hi,

i found out that is has something to do with gateway groups. If i use a single gateway for dyndns it works. If i switch to a gateway group dyndns won't work anymore.

Regards

Stephan

I am experiencing the same issue.  DynDNS works with a single gateway but fails when you set it to monitor a gateway group.

I've got the same error.

PHP Errors:

[19-Jul-2019 05:52:02 Europe/Zurich] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc on line 758
[19-Jul-2019 05:52:42 Europe/Zurich] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc on line 758
[19-Jul-2019 05:53:19 Europe/Zurich] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc on line 758


May this is the case because IPv6 isn't disabled, and tries to update with the fe80: adress? I don't monitor a gateway group, but the WAN interface - which is listed as WAN_DHCP6 / WAN_DHCP under Single Gateway.

But actually the Update itself works regardless of the failure.

Hello,

as Franco has already written, this is just a PHP warning. This can be ignored.
The problem right now is that you can't use gateway groups for DynDNS anymore. Of course this is not nice, because you can't implement failover scenarios anymore.


Regards

Stephan

July 22, 2019, 10:57:56 AM #6 Last Edit: July 23, 2019, 03:51:15 PM by SoGX
Maybe it has something to do with an additional IPv6 gateway that appeared after the update.
This cannot be deleted or changed.

Hello,
after upgrade to 19.7, i also have problem that dyndns cannot monitor failover gateway group.

This error is still present with the upgrade to 19.7.2.  All good with dismissing and ignoring given that it's non-critical but mentioning still because I'm not sure devs test this scenario.

PHP Warning:  Invalid argument supplied for foreach() in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc on line 758

Same here:
[14-Aug-2019 18:00:27 America/New_York] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc on line 758

Still same here on OPNsense 19.7.2.

[17-Aug-2019 23:40:05 America/Chicago] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc on line 758

Any news? Between this and some other issues I've been encountering, I've wondered if it might be safer to switch to pfSense?

This error is still present with the upgrade to 19.7.5_5.

Still an issue with OPNsense 19.7.5 bb0e6e52c

Instead of claiming that this is not an issue and pointing to the fact that PHP warnings were turned back on in 19.7, please explain what is causing this and how to fix it.  This message is indicating that an action is SUPPOSED to be performed "For Each" instance of something...

Based on the discussion it seems to be stating that an action is supposed to be performed for each Gateway in a list... How do we fix our configs so that our error log isn't listing this supposedly not important error (so that we can focus on things that are actual security / operational concerns)?

Why don't you try 19.7.10 before posting about 19.7.5. ;)


Cheers,
Franco

Quote from: franco on February 17, 2020, 11:18:11 AM
Why don't you try 19.7.10 before posting about 19.7.5. ;)


Cheers,
Franco

i'm still seeing this error in 20.1.1