nginx: issue is fixed, but fix never made it into OPNsense

Started by dinguz, March 13, 2025, 10:55:33 AM

Previous topic - Next topic
Print
Go Down Pages1
User actions
March 13, 2025, 10:55:33 AM
I reported the issue here https://forum.opnsense.org/index.php?topic=44880.0
Created a github issue as requested: https://github.com/opnsense/core/issues/8176

Now the issue has apparently been fixed in github by kulikov-a, but the fixes never made it into OPNsense.
Could someone have a look at this?
In theory there is no difference between theory and practice. In practice there is.
March 13, 2025, 01:49:15 PM #1
> The reported issue seems to be fixed by these commits. Can we please have this included in OPNsense?

Not in our repo, someone needs to do a PR...
March 13, 2025, 01:55:49 PM #2
Unfortunately, I'm not too familiar with GitHub procedures or etiquette. Can I create a PR myself, or is that up to the author of the patch?
In theory there is no difference between theory and practice. In practice there is.
March 13, 2025, 02:24:24 PM #3
Anyone can, but ideally the author should. A ping on your issue might be enough.
March 31, 2025, 03:30:29 PM #4
A PR has been made according to Github, but I guess it didn't make it into 25.1.4?
In theory there is no difference between theory and practice. In practice there is.
March 31, 2025, 03:32:23 PM #5
Yes.
Print
Go Up Pages1
User actions