[SOLVED] Why bother downloading Bogons v6 when they're not used?

[Evert]

Code: [Select]

2024-11-07T03:05:02+01:00 PM0.arkivo.no root 27472 - [meta sequenceId="1"] bogons update is beginning the update cycle
2024-11-07T03:05:02+01:00 PM0.arkivo.no root 40527 - [meta sequenceId="2"] Bogons V4 file downloaded: no changes.
2024-11-07T03:05:02+01:00 PM0.arkivo.no root 52169 - [meta sequenceId="3"] Bogons V6 file downloaded but not updating IPv6 bogons table because IPv6 Allow is off
2024-11-07T03:05:02+01:00 PM0.arkivo.no root 54919 - [meta sequenceId="4"] update bogons is ending the update cycle

Why not first check the state of IPv6 Allow, and base whether Bogons V6 gets downloaded on that? 

[franco]

Mostly to bridge the gap between disabling and enabling IPv6 and getting the correct values on the switch. The file on the mirror is 90 kb and contains both IPv4 and IPv6 anyway


Cheers,
Franco

[Evert]

So it's a single file? The log suggests it was 2 separate files.

Yeah, if it's a single file anyway, then I guess it's fine 

[franco]

Yeah, valid concern in any case. The script has other issues but let's just fix the wording:

https://github.com/opnsense/core/commit/671f4d44159


Thanks,
Franco