[SOLVED] Error message during upgrade to 23.1.3 (OPNsense\Quagga\BGP Migration..

[wstemb]

During the last upgrade  from 23.1.2 to 23.1.3 i got the message during the upgrade:

...
Starting configd.
>>> Invoking update script 'refresh'
*** OPNsense\Quagga\BGP Migration failed, check log for details
...

No visible effect on the firewall. It seems it is working OK.

I have the FRR plugin installed (configured, but not functional at the moment - planned to use for OSPF):

os-frr (installed)   1.32_1   378KiB   OPNsense   The FRRouting Protocol Suite

Never intentionally installed quagga, the only places in the file system I can find "quagga" are:

/usr/local/opnsense/scripts/quagga   (used in /etc/rc.conf.d/frr )
/usr/local/opnsense/www/js/quagga

Walter

[franco]

Hi Walter,

There should be an error in the system log. You can force it to appear as follows:

# /usr/local/opnsense/mvc/script/run_migrations.php


Cheers,
Franco

[wstemb]

The command returns no new information, just one line: :

*** OPNsense\Quagga\BGP Migration failed, check log for details

Walter

[franco]

System: Log Files: General ;)


Cheers,
Franco

[wstemb]

Sorry! Misunderstood your post.

Here is the log:

2023-03-13T10:52:50   Error   config   #2 {main} )   
2023-03-13T10:52:50   Error   config   #1 /usr/local/opnsense/mvc/script/run_migrations.php(54): OPNsense\Base\BaseModel->runMigrations()   
2023-03-13T10:52:50   Error   config   #0 /usr/local/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php(706): OPNsense\Base\BaseModel->serializeToConfig()   
2023-03-13T10:52:50   Error   config   Stack trace:   
2023-03-13T10:52:50   Error   config   in /usr/local/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:583   
2023-03-13T10:52:50   Error   config   [2023-03-13T10:52:50+01:00][ERROR] Model OPNsense\Quagga\BGP can't be saved, skip ( OPNsense\Phalcon\Filter\Validation\Exception: [OPNsense\Quagga\BGP:asnumber] invalid integer value{}   
2023-03-13T10:52:50   Error   config   [2023-03-13T10:52:50+01:00][ERROR] [OPNsense\Quagga\BGP:asnumber] invalid integer value{}

[franco]

Can you also grep this for me?

# grep asnumber /conf/config.xml


Thanks,
Franco

[wstemb]

Empty string.
Checked also by editor, there is no asnumber string in config.xml

Walter

[franco]

Thanks then let's try this: https://github.com/opnsense/plugins/commit/f3b14c91e64

# opnsense-patch -c plugins f3b14c91e64

And rerun the migration script.


Cheers,
Franco

[wstemb]

Done, here is the output (last line of the patch output and run migrations):

...
All patches have been applied successfully.  Have a nice day.
root@guardian:/conf # /usr/local/opnsense/mvc/script/run_migrations.php
Migrated OPNsense\Quagga\BGP from 0.0.0 to 1.0.7

No errors in log.

Can I mark the post as Solved?

Thank you and  greetings
Walter

[franco]

Hi Walter,

Just to be sure this is still empty, right?

# grep asnumber /conf/config.xml

You can edit the first post subject to add [SOLVED] manually.


Cheers,
Franco

[wstemb]

No, here is the result:

# grep asnumber /conf/config.xml
        <asnumber>65551</asnumber>

Walter

[franco]

Ok, fair enough. I suppose that's how it works and you need to add your AS number anyway if BGP is to be configured. At least this 65551 value will not be routed if enabled falsely.


Cheers,
Franco

[wstemb]

In the previous  version, under <quagga>, there was not the <bgp ... > section, now it is: 

      <bgp version="1.0.7">
        <enabled>0</enabled>
        <asnumber>65551</asnumber>
        <routerid/>
        <graceful>0</graceful>
        <networkimportcheck>1</networkimportcheck>
        <networks/>
        <redistribute/>
        <neighbors/>
        <aspaths/>
        <prefixlists/>
        <communitylists/>
        <routemaps/>
      </bgp>

I can see it now in web ui,  in the Routing:BGP, it  is not enabled.

I have no plans in near future to use BGP here, I installed the FRR plugin just for OSPF, to migrate an existing connection from other equipment to OPNSense.

Thanks, Walter

[franco]

Thanks for the details. That must have been a rather old install that actually used quagga back in the day?


Cheers,
Franco

[wstemb]

No, it is pretty fresh. Installed in December on 22.7.x, upgraded to 23.1, installed FRR for OSPF ten days ago on 23.1.1, upgraded to 23.1.2 (with a reboot, did not see errors, maybe I missed something), after that upgraded on 23.1.3 with the error.

Never used or installed quagga intentionally. I will check in config backups if FRR plugin install created this quagga section.

My sensation is that there is an error in the upgrade procedure forcing some parameters not needed for BGP if not used and receiving non zero RC code. We made a workaround patching the config. Good enough for me.

Walter