Webgui system/firmware broken after Upgrade to 21.1.3

[Nagilum]

"opnsense upgraded: 21.1 -> 21.1.3"

- I upgraded it via webgui and ran into the problem.
- To be sure I downloaded the 21.1 DVD iso, bootet, load the current configuration and reinstalled | Problem fix'd.
- Re-ran the update to latest packages & version via webgui again
-> System broken again!

See attachements.

[mmo]

Here is the Title Link of all Widgets Broken

[franco]

Looks like JavaScript isn't executing. What browser is this and what is the console error?


Cheers,
Franco

[Nagilum]

As you say JavaScript: Access fixed for me (though it should still be a bug) by switching to Firefox 86.0 portable.
I was using Internet Explorer 11.4046... as I was using Windows Server 2016 to access it.

 How do I get the console error? Just watching console for errors?

[franco]

I don't have such a system but the Internet says the browser console is accessed with "F12".


Cheers,
Franco

[mrkev]

ignore... already been reported 

[Nagilum]

ignore... already been reported 

To make things consistent, it's common to post the link, if already reported somewhere else.
I didn't see that before.

[Fright]

typical IE incompatibility
its on

Code: [Select]

function upgrade_ui(major = false)in firmware.volt
ie not support default parameter
and

Code: [Select]

Object.assignin views/layouts/default.volt (he throws it for a long time)
also not supported by IE
@Nagilum
if I may, although I'm not a dev and this is easily fixable, but it's really time to think about avoiding using IE for anything other than internal corporate systems. really hard to maintain backward compatibility with IE all the time

[Nagilum]

It's just what you have 'on hand' when you work on a Server (VM). It still worked with the 21 ISO, so one doesn't expect it to break when doing an update.

If you (intentionally) don't support it anymore, put in a browser switch with a warning, so ppl. at least have an info about (and you might have less tickets). ;-)

As I know that current Firefox is working, I can continue work, but that was unlucky and cost me quite some time to debug (and document to report the problem).

[Fright]

If you (intentionally) don't support it anymore, put in a browser switch with a warning, so ppl

no, it's just my 2 cents
quickly ran through the menu and did not notice other errors in IE

[franco]

I don't mind removing the default parameter from JS. IE 11 is still supported till August so retaining what we had is reasonable.


Cheers,
Franco

[franco]

Here's the patch https://github.com/opnsense/core/commit/210753253

# opnsense-patch 210753253

Tests welcome. Might be a hotfix candidate if the dashboard situation is being improved anyway.


Cheers,
Franco

[miroco]

If you need to remove a patch, do you still run it a second time?

https://forum.opnsense.org/index.php?topic=4682.msg18201#msg18201


miroco

[franco]

Yes, still the same.


Cheers,
Franco

[Nagilum]

Patch works!

I'm overwhelmed from response time and how easy you made it to apply the commit/patch and make one able to test it.