os-acme-client error in 20.1.7

[dinguz]

After the upgrade, I get this warning every time the script is being run from cron:

20 00:05:00 Europe/Amsterdam] PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 1421
[22-May-2020 00:05:00 Europe/Amsterdam] PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 1428

[Maurice]

Same here. Probably related to PHP 7.3 update?
But it's just a warning, I haven't observed any actual malfunction. Did you?

[STRUBartacus]

Same here, but no problems observed...

[Maurice]

Already fixed: https://github.com/opnsense/plugins/commit/ee799d8c75f7aaffaee97439c95fd98263eb1b38

[franco]

Slipped through our screening process, but at least has no averse affects on operation.


Cheers,
Franco

[cpw]

It generated an "issue has occurred, report it" warning for me overnight. Glad it's been fixed..

[STRUBartacus]

It generated an "issue has occurred, report it" warning for me overnight. Glad it's been fixed..

Just disable the "AcmeClient Cronjob" until the next update... (do not forget to renew the certificates before)

[franco]

Why o why, it's just a warning pointing to bad programming style and everything keeps working. Disabling your cron job will disable your renew...


Cheers,
Franco