Cicada Theme -> Franco didnt want the cicada theme - so deleted!

[mimugmail]

Just a note to everyone, I have received an apology from noname123123 and I hope so has @franco, so lets give the guy some slack now. We all have lessons to learn in life and none of us are perfect, well most of you aren't  :P

I would ask the mod to delete this thread after a few days so we can close this chapter and move on. I'll be taking the Cicada theme under my wings and helping to get it pushed through.

Thank you again for your welcome. I just want to say that anyone who wants to improve the cicada theme can do it. color technology can be there a lot better. I'm also working on a new theme that is just the opposite of dark. will soon put a few screenshots of the new template then online here. thanks again for your support.

If you push Cicada again this will be the same old problems. Please consider in improving the existing dark theme. You'll collect some experiences how Github works and how to work in a team. It can and will be disappointing at some stage, but everyone contributing code in a project has to learn to live with it (so as I).

For a new theme there's no worries to create a new pull request, but please, do your first run with some small PR's to an existing theme. I can't count how many github mails I received from openend and closed PR's ;)

I invite you to join the IRC channel and I can give you a short introduction to Github (also in German).

[marjohn56]

If you push Cicada again this will be the same old problems. Please consider in improving the existing dark theme. You'll collect some experiences how Github works and how to work in a team. It can and will be disappointing at some stage, but everyone contributing code in a project has to learn to live with it (so as I).

For a new theme there's no worries to create a new pull request, but please, do your first run with some small PR's to an existing theme. I can't count how many github mails I received from openend and closed PR's ;)

I invite you to join the IRC channel and I can give you a short introduction to Github (also in German).

I have taken this under my wing and have committed it this morning after testing it for a couple of days. There are sufficient differences between the two themes to have both. Yes, they are both dark, but Cicada uses different fonts and uses different colours in many places. I personally prefer Rebellion, others prefer Cicada.

For those wishing to try it, use the following method to install from the commit....once accepted.

# opnsense-code plugins
# cd /usr/plugins/misc/theme-cicada
# make upgrade

[opnsenseuser]

If you push Cicada again this will be the same old problems. Please consider in improving the existing dark theme. You'll collect some experiences how Github works and how to work in a team. It can and will be disappointing at some stage, but everyone contributing code in a project has to learn to live with it (so as I).

For a new theme there's no worries to create a new pull request, but please, do your first run with some small PR's to an existing theme. I can't count how many github mails I received from openend and closed PR's ;)

I invite you to join the IRC channel and I can give you a short introduction to Github (also in German).

I have taken this under my wing and have committed it this morning after testing it for a couple of days. There are sufficient differences between the two themes to have both. Yes, they are both dark, but Cicada uses different fonts and uses different colours in many places. I personally prefer Rebellion, others prefer Cicada.

For those wishing to try it, use the following method to install from the commit....once accepted.

# opnsense-code plugins
# cd /usr/plugins/misc/theme-cicada
# make upgrade

thx very much!

maybe there are a few things we can take over from the cicada theme to the dark theme!

[marjohn56]

Let's leave them separate. As I said, they are sufficiently different to both exist. I prefer Rebellion, but it's personal taste.

[franco]

Thanks to everyone. For me the matter is resolved as well and we can move on.

I've asked noname12123 to take a little time to help shape the core theme issues as well as building the perfect theme in the plugins. The former helps everyone, helps to see how we communicate and review and improve so that the process for larger changes is more smooth for everyone involved.

Special thanks to Martin for helping noname12123 with the theme plugin inclusion.


Cheers,
Franco