Messages

[and]

Thanks for the quick turn-around on the patch! :)

I can confirm that this fixed the issue, just wrapped up some verification testing on my 19.7.4 setup:

• I re-enabled Captive Portal and confirmed things were broken again, before patching
• Applied the patch via opnsense-patch
• Rebooted, and then confirmed clients were able to authenticate and get to the Internet

I also noted the difference in the "ipfw table all list" output pre- and post-patch, confirming that that looks more correct now with the table entries per IP now pointing to a relevant ipfw rule number.

Pre-patch:

Code Select Expand

# ipfw table all list
--- table(0), set(0) ---
192.168.12.10/32 0
192.168.12.20/32 0
192.168.12.100/32 0
192.168.12.120/32 0


Patched:

Code Select Expand

# ipfw table all list
--- table(0), set(0) ---
192.168.12.10/32 30002
192.168.12.20/32 30001
192.168.12.100/32 30003
192.168.12.120/32 30000


P.S. While we're talking about the Captive Portal feature, I've been meaning to submit a patch or make a small request for awhile now: could the portal login page be fixed in the default template where the Enter key would work as a submit action? This works for the main OPNsense admin login screen, but not for the portal login screen. It would let users more quickly submit the form instead of mousing around to click the Login button. I think we're just missing type="submit" in the login button tag?

I suspect this is a regression between 19.7.3 and 19.7.4, and I think I can pinpoint the breaking code commit:

I've had a working OPNsense Captive Portal setup for months now, most recently working on 19.7.3. Then, last night I upgraded to 19.7.4 and Captive Portal broke after the upgrade.

Inspecting the Changelog for 19.7.4, I see: "captive portal: optimise ipfw rule parsing"

Which seems to correspond with this commit that went into 19.7.4: https://github.com/opnsense/core/commit/ffcd85f116efa

I've had to disable the Captive Portal zone in order to get Internet-bound traffic working again. With Captive Portal enabled in 19.7.4, even after signing in on the portal login page, user gets redirected to portal page with "logout" button and traffic still can't egress to the Internet even though their session shows up in the Sessions page.