OPNsense
  • Home
  • Help
  • Search
  • Login
  • Register

  • OPNsense Forum »
  • English Forums »
  • Development and Code Review (Moderator: fabian) »
  • Dual Stack Lite (DS-Lite) Support
« previous next »
  • Print
Pages: 1 [2] 3

Author Topic: Dual Stack Lite (DS-Lite) Support  (Read 23953 times)

noctarius

  • Newbie
  • *
  • Posts: 14
  • Karma: 3
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #15 on: April 10, 2018, 05:00:15 pm »
And one more question, how can I hook into the dhcp6c events? I need to create/recreate the tunnel when the WAN IPv6 changes (yes in Germany you get crappy "dynamic" prefixes assigned).
Logged

noctarius

  • Newbie
  • *
  • Posts: 14
  • Karma: 3
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #16 on: April 10, 2018, 05:56:11 pm »
Sorry for spamming ;-)

Ok I fixed the first bit of the overall issue. I'm now able to create a GIF tunnel with an outer set of IPv6 addresses which is obviously necessary for a 4in6 tunnel. Please find the according pull request: https://github.com/opnsense/core/pull/2341

Next step would be to get additional parameters, like mtu, -raccept_rtadv (or better ifdisabled) into the UI and the controller. You guys are probably way faster to do this :)
Logged

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 17656
  • Karma: 1610
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #17 on: April 10, 2018, 07:43:00 pm »
We appreciate all hands for coding. What I can offer is post-code review and pre-code discussion and walk you through it. Easiest way to talk is via Freenode IRC #opnsense.


Cheers,
Franco
Logged

noctarius

  • Newbie
  • *
  • Posts: 14
  • Karma: 3
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #18 on: April 10, 2018, 07:56:48 pm »
That at least helps, since I still have some things I'm not aware how to solve, like how I have to hook myself into the DHCP6 response :) Happy for any hint. Joined the IRC channel!
Logged

noctarius

  • Newbie
  • *
  • Posts: 14
  • Karma: 3
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #19 on: May 01, 2018, 10:38:18 pm »
Ok after I'm back from conference work, I took the day off to work a bit on the implementation. I added the option to send the raw-option response to the script which is executed when a dhcp response is received and I added (I guess) most code on the UI / backend side.

https://github.com/opnsense/dhcp6c/pull/1
https://github.com/opnsense/core/pull/2382
Logged

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 17656
  • Karma: 1610
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #20 on: May 02, 2018, 03:49:59 pm »
Good progress! For reference we discussed how to integrate this step by step. Next is the dhcp6c raw options and AFTR changes. It requires a little review of the raw options patch. 18.1.7 moves to our dhcp6c client code so 18.1.8 could see the addition of raw options.


Cheers,
Franco
Logged

noctarius

  • Newbie
  • *
  • Posts: 14
  • Karma: 3
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #21 on: May 02, 2018, 08:44:39 pm »
Quote from: franco on May 02, 2018, 03:49:59 pm
Good progress! For reference we discussed how to integrate this step by step. Next is the dhcp6c raw options and AFTR changes. It requires a little review of the raw options patch. 18.1.7 moves to our dhcp6c client code so 18.1.8 could see the addition of raw options.

Right, the dhcp6c changes (the original raw-options patch) needs to get in first. Then we need my addition to the raw-options patch (which also needs to be tested, so far all is just hacked down, so I consider it all WIP ;-)). Finally the DS-Lite UI / backend patches can be added :-)
Logged

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #22 on: May 04, 2018, 06:51:49 pm »
I can either send you my dhcp6c source with the raw options or you can send me your patches and I'll work them in, which do you want to do?

Probably easier if I send you the source as you know what you are looking for on the in/out.
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 17656
  • Karma: 1610
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #23 on: May 05, 2018, 11:12:55 am »
It's all here on top of your changes for raw options (extra branch but going to be merged for 18.1.8).

https://github.com/opnsense/dhcp6c/pull/1


Cheers,
Franco
Logged

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #24 on: May 05, 2018, 11:44:06 am »
Bugger... just spent the last hour adding the raw opts stuff..  ::)
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

noctarius

  • Newbie
  • *
  • Posts: 14
  • Karma: 3
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #25 on: May 05, 2018, 05:25:57 pm »
Is your solution better? Not a C-Guy anymore, therefore if your patch is cleaner and resolves in the same / similar output, happy to go with it too :)
Logged

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #26 on: May 05, 2018, 06:51:29 pm »
Confused now...

I added my original RAW options to the opnsense/dhcp6c, which is a version of my original PR that added config re-read in SIGHUP and also had all the RAW options stuff. Franco wanted to break it into two parts, first part was the config re-read which is now in 18.1.7 and the RAW options bit was next. However when looking at the source this morning for https://github.com/opnsense/dhcp6c there were no RAW options hence I then re-added them.

@franco - please de-confuse me.
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 17656
  • Karma: 1610
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #27 on: May 05, 2018, 07:20:01 pm »
Martin, there are two branches in that repo: https://github.com/opnsense/dhcp6c/branches

I assume you saw the commit I added, because you commented on it. ;)

https://github.com/opnsense/dhcp6c/commit/a716d4bfc97

I took this from the ports submission, cleaned up a few whitespace issues only.

SIGHUP is on master *and* shipped with 18.1.7. :)


Cheers,
Franco
Logged

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #28 on: May 06, 2018, 12:36:09 am »
OK... My brain still appears to be on central american time...  8)

I'll take a look on Monday as it's a public holiday here.

Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud

marjohn56

  • Hero Member
  • *****
  • Posts: 1701
  • Karma: 179
    • View Profile
Re: Dual Stack Lite (DS-Lite) Support
« Reply #29 on: May 08, 2018, 01:56:47 pm »
OK... @franco is now merging dpinger so I can work on this with @noctarius.

@noctarios - where are you at with dhcp6c?
Logged
OPNsense 24.7 - Qotom Q355G4 - ISP - Squirrel 1Gbps.

Team Rebellion Member - If we've helped you remember to applaud
  • Print
Pages: 1 [2] 3
« previous next »
  • OPNsense Forum »
  • English Forums »
  • Development and Code Review (Moderator: fabian) »
  • Dual Stack Lite (DS-Lite) Support
 

OPNsense is an OSS project © Deciso B.V. 2015 - 2024 All rights reserved
  • SMF 2.0.19 | SMF © 2021, Simple Machines
    Privacy Policy     | XHTML | RSS | WAP2