OPNsense
  • Home
  • Help
  • Search
  • Login
  • Register

  • OPNsense Forum »
  • Archive »
  • 18.1 Legacy Series »
  • [isolated: see #91] PPPoE reconnect loop
« previous next »
  • Print
Pages: 1 ... 3 4 [5] 6 7

Author Topic: [isolated: see #91] PPPoE reconnect loop  (Read 55122 times)

nallar

  • Newbie
  • *
  • Posts: 15
  • Karma: 4
    • View Profile
Re: PPPoE reconnect loop
« Reply #60 on: March 07, 2018, 03:13:35 pm »
Applied the patch and changed IPv6 address back to none.

No reconnect loop yet, but it didn't always happen before so can't confirm that it is fixed.
Logged

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 13602
  • Karma: 1170
    • View Profile
Re: PPPoE reconnect loop
« Reply #61 on: March 07, 2018, 04:50:27 pm »
No rush, if you can let us know in a week or two. :)


Thanks,
Franco
Logged

schnipp

  • Sr. Member
  • ****
  • Posts: 286
  • Karma: 13
    • View Profile
Re: PPPoE reconnect loop
« Reply #62 on: March 11, 2018, 04:14:00 pm »
Within this thread users address different issues with PPPoE dial-up. Some have problems with IPv6 address assignment, others with keep-alive signaling to the ISP.

Unfortunately, with update from 18.1.2 to 18.1.4 my problem (keep-alive signaling to the ISP by use of PPP LCP echo request/reply) is not solved. Instead the problem got more worse because in case of re-establishing the PPPoE session the mpd5 daemon does not send any PPP LCP packets to the ISP anymore. So from now on, also PPP configuration requests are not answered.  :'(

My guess is, there could be some bugs in the mpd5 daemon. The source code is not high quality (not well documented, a lot of immediates deeply integrated in the source code in conjunction with a lot of pointer arithmetics) :( So, it is hard to debug on a productive system without gdb.

Does anybody know, what has changed in the daemons source code related to the Opnsense update mentioned above?

Logged
OPNsense 22.7.10_2-amd64

elektroinside

  • Hero Member
  • *****
  • Posts: 574
  • Karma: 51
    • View Profile
Re: PPPoE reconnect loop
« Reply #63 on: March 11, 2018, 05:08:10 pm »
Franco said there will be several PPPoE improvements in the upcoming service releases. I'm confident most issues will get fixed. I have sent Franco some logs regarding these new changes via email, I guess if it's possible you can also jump in. I'm sure he's doing his best to get these done as soon as possible...
Logged
OPNsense v18 | HW: Gigabyte Z370N-WIFI, i3-8100, 8GB RAM, 60GB SSD, | Controllers: 82575GB-quad, 82574, I221, I219-V | PPPoE: RDS Romania | Down: 980Mbit/s | Up: 500Mbit/s

Team Rebellion Member

schnipp

  • Sr. Member
  • ****
  • Posts: 286
  • Karma: 13
    • View Profile
Re: PPPoE reconnect loop
« Reply #64 on: March 11, 2018, 06:22:51 pm »
Quote from: elektroinside on March 11, 2018, 05:08:10 pm
[...]
I guess if it's possible you can also jump in. I'm sure he's doing his best to get these done as soon as possible...

That sounds good  :). I am still investigating with my self-compiled debug version of mpd5. I have to check whether the ppp netgraph node (see mpd32168-wan in reply #67) successfully forwards packets from hook bypass to link0.

 
Logged
OPNsense 22.7.10_2-amd64

elektroinside

  • Hero Member
  • *****
  • Posts: 574
  • Karma: 51
    • View Profile
Re: PPPoE reconnect loop
« Reply #65 on: March 12, 2018, 07:07:07 am »
Has this been reported on github?
It is getting bigger (the thread) and I think it's time to open a ticket there... it will be easier for the devs to follow the progress. Also, not all of them are reading the forum.
I think it's a better idea than emailing logs. We can all contribute there...
« Last Edit: March 12, 2018, 07:16:34 am by elektroinside »
Logged
OPNsense v18 | HW: Gigabyte Z370N-WIFI, i3-8100, 8GB RAM, 60GB SSD, | Controllers: 82575GB-quad, 82574, I221, I219-V | PPPoE: RDS Romania | Down: 980Mbit/s | Up: 500Mbit/s

Team Rebellion Member

mimugmail

  • Hero Member
  • *****
  • Posts: 6281
  • Karma: 432
    • View Profile
Re: PPPoE reconnect loop
« Reply #66 on: March 12, 2018, 12:28:31 pm »
Quote from: schnipp on March 11, 2018, 04:14:00 pm
Within this thread users address different issues with PPPoE dial-up. Some have problems with IPv6 address assignment, others with keep-alive signaling to the ISP.

Unfortunately, with update from 18.1.2 to 18.1.4 my problem (keep-alive signaling to the ISP by use of PPP LCP echo request/reply) is not solved. Instead the problem got more worse because in case of re-establishing the PPPoE session the mpd5 daemon does not send any PPP LCP packets to the ISP anymore. So from now on, also PPP configuration requests are not answered.  :'(

My guess is, there could be some bugs in the mpd5 daemon. The source code is not high quality (not well documented, a lot of immediates deeply integrated in the source code in conjunction with a lot of pointer arithmetics) :( So, it is hard to debug on a productive system without gdb.

Does anybody know, what has changed in the daemons source code related to the Opnsense update mentioned above?

You can revert to old version to check if it really was the change by franco:

opnsense-revert -r 18.1.2 mpd5
Logged
Twitter: mimu_muc
WWW: www.routerperformance.net
Support plans: https://www.max-it.de/en/it-services/opnsense/
Commercial Plugins (German): https://opnsense.max-it.de/

franco

  • Administrator
  • Hero Member
  • *****
  • Posts: 13602
  • Karma: 1170
    • View Profile
Re: PPPoE reconnect loop
« Reply #67 on: March 12, 2018, 03:17:23 pm »
It's not my change, it was FreeBSD and it was documented in 18.1.3...

https://github.com/opnsense/changelog/blob/master/doc/18.1/18.1.3#L49
Logged

mimugmail

  • Hero Member
  • *****
  • Posts: 6281
  • Karma: 432
    • View Profile
Re: PPPoE reconnect loop
« Reply #68 on: March 12, 2018, 03:32:39 pm »
Oh, I thought you said last time you recompiled it. Ok, then it's FreeBSD but the revert should still do the trick :)
Logged
Twitter: mimu_muc
WWW: www.routerperformance.net
Support plans: https://www.max-it.de/en/it-services/opnsense/
Commercial Plugins (German): https://opnsense.max-it.de/

schnipp

  • Sr. Member
  • ****
  • Posts: 286
  • Karma: 13
    • View Profile
Re: PPPoE reconnect loop
« Reply #69 on: March 14, 2018, 07:59:06 pm »
Quote from: elektroinside on March 12, 2018, 07:07:07 am
Has this been reported on github?
It is getting bigger (the thread) and I think it's time to open a ticket there... it will be easier for the devs to follow the progress. Also, not all of them are reading the forum.

No, it hasn't been yet reported. The last ticket I opened some time ago has not been paid any attention (see issue #1961). Thus, regarding this topic, I opened the discussion in the forum. But, we can try to move it to the issue tracker.

 
« Last Edit: March 14, 2018, 08:00:42 pm by schnipp »
Logged
OPNsense 22.7.10_2-amd64

elektroinside

  • Hero Member
  • *****
  • Posts: 574
  • Karma: 51
    • View Profile
Re: PPPoE reconnect loop
« Reply #70 on: March 14, 2018, 08:07:14 pm »
Please do. I am almost sure it was taken into consideration. At least the devs know PPPoE has issues. As I remember correctly, Franco was actively talking about these on the FreeBSD bugtracker. He also told me fixes/improvements are scheduled  :-)
Logged
OPNsense v18 | HW: Gigabyte Z370N-WIFI, i3-8100, 8GB RAM, 60GB SSD, | Controllers: 82575GB-quad, 82574, I221, I219-V | PPPoE: RDS Romania | Down: 980Mbit/s | Up: 500Mbit/s

Team Rebellion Member

schnipp

  • Sr. Member
  • ****
  • Posts: 286
  • Karma: 13
    • View Profile
Re: PPPoE reconnect loop
« Reply #71 on: March 18, 2018, 02:17:41 pm »
I have created a new bug report (#2267) https://github.com/opnsense/core/issues/2267
Logged
OPNsense 22.7.10_2-amd64

elektroinside

  • Hero Member
  • *****
  • Posts: 574
  • Karma: 51
    • View Profile
Re: PPPoE reconnect loop
« Reply #72 on: March 19, 2018, 09:02:54 am »
Quote from: schnipp on March 18, 2018, 02:17:41 pm
I have created a new bug report (#2267) https://github.com/opnsense/core/issues/2267

Thanks. Let's see what progress we'll have.
Logged
OPNsense v18 | HW: Gigabyte Z370N-WIFI, i3-8100, 8GB RAM, 60GB SSD, | Controllers: 82575GB-quad, 82574, I221, I219-V | PPPoE: RDS Romania | Down: 980Mbit/s | Up: 500Mbit/s

Team Rebellion Member

mimugmail

  • Hero Member
  • *****
  • Posts: 6281
  • Karma: 432
    • View Profile
Re: PPPoE reconnect loop
« Reply #73 on: March 19, 2018, 10:05:22 am »
btw .. this weekend I got my new fiber dsl and I had a similar problem with a Cisco Router as client.
The reason was the Cisco was not able to tag VLAN7 on a SVI port (just unsupported), but when firing up debugging I read about ongoing LCP timeouts and thought of you.

@schnipp: Do you use VLANs for PPPoE? I can't imagine this is a general problem but perhaps something that with a reconnect mpd can't push into VLAN
Logged
Twitter: mimu_muc
WWW: www.routerperformance.net
Support plans: https://www.max-it.de/en/it-services/opnsense/
Commercial Plugins (German): https://opnsense.max-it.de/

mimugmail

  • Hero Member
  • *****
  • Posts: 6281
  • Karma: 432
    • View Profile
Re: PPPoE reconnect loop
« Reply #74 on: March 19, 2018, 11:19:08 am »
Another idea ... go to cli and edit:

/usr/local/opnsense/service/templates/OPNsense/IPFW/ipfw.conf

Search for rule 150 and add log option:

add 150 deny log layer2 not mac-type ip,ipv6

Then restart configd:

service configd restart

Via UI go to Traffic Shaper and hit "Reset".

Then back to CLI and type:

sysctl net.inet.ip.fw.verbose_limit=5



Perhaps you see something blocked in system.log or filter.log. Just a guess since it hit upon this rules which blocks everything and *could* be related to non ipv4/6
Logged
Twitter: mimu_muc
WWW: www.routerperformance.net
Support plans: https://www.max-it.de/en/it-services/opnsense/
Commercial Plugins (German): https://opnsense.max-it.de/

  • Print
Pages: 1 ... 3 4 [5] 6 7
« previous next »
  • OPNsense Forum »
  • Archive »
  • 18.1 Legacy Series »
  • [isolated: see #91] PPPoE reconnect loop
 

OPNsense is an OSS project © Deciso B.V. 2015 - 2023 All rights reserved
  • SMF 2.0.19 | SMF © 2021, Simple Machines
    Privacy Policy
    | XHTML | RSS | WAP2