os-git-backup error with 26.1-r2_2

[meyergru]

I got a log entry about a failed Github configuration backup, but I first thought this was because of a false positive in one of my blocklists blocking github.com. Now I found that when I started the configuration backup manually, I see an error on the web page reading:

Code Select Expand

Fatal error: Uncaught ValueError: The arguments array must contain 2 items, 1 given in /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php:55 Stack trace: #0 /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php(55): vsprintf('(/usr/local/bin...', Array) #1 /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php(109): OPNsense\Core\Shell::exec_safe(Array, Array) #2 /usr/local/opnsense/mvc/app/library/OPNsense/Backup/Git.php(182): OPNsense\Core\Shell::shell_safe(Array, 'master:main') #3 /usr/local/www/diag_backup.php(395): OPNsense\Backup\Git->backup() #4 {main} thrown in /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php on line 55

The stack trace in the crash reporter was:

Code Select Expand

[28-Jan-2026 01:08:12 Europe/Berlin] PHP Fatal error:  Uncaught ValueError: The arguments array must contain 2 items, 1 given in /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php:55
Stack trace:
#0 /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php(55): vsprintf('(/usr/local/bin...', Array)
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php(109): OPNsense\Core\Shell::exec_safe(Array, Array)
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Backup/Git.php(182): OPNsense\Core\Shell::shell_safe(Array, 'master:main')
#3 /usr/local/opnsense/scripts/system/remote_backup.php(17): OPNsense\Backup\Git->backup()
#4 {main}
  thrown in /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php on line 55
[28-Jan-2026 13:11:24 Europe/Berlin] PHP Fatal error:  Uncaught ValueError: The arguments array must contain 2 items, 1 given in /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php:55
Stack trace:
#0 /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php(55): vsprintf('(/usr/local/bin...', Array)
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php(109): OPNsense\Core\Shell::exec_safe(Array, Array)
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Backup/Git.php(182): OPNsense\Core\Shell::shell_safe(Array, 'master:main')
#3 /usr/local/www/diag_backup.php(395): OPNsense\Backup\Git->backup()
#4 {main}
  thrown in /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php on line 55
[28-Jan-2026 13:19:45 Europe/Berlin] PHP Fatal error:  Uncaught ValueError: The arguments array must contain 2 items, 1 given in /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php:55
Stack trace:
#0 /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php(55): vsprintf('(/usr/local/bin...', Array)
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php(109): OPNsense\Core\Shell::exec_safe(Array, Array)
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Backup/Git.php(182): OPNsense\Core\Shell::shell_safe(Array, 'master:main')
#3 /usr/local/www/diag_backup.php(395): OPNsense\Backup\Git->backup()
#4 {main}
  thrown in /usr/local/opnsense/mvc/app/library/OPNsense/Core/Shell.php on line 55


[franco]

Thanks, likely this:

# opnsense-patch https://github.com/opnsense/plugins/commit/4212ffea8c2c


Cheers,
Franco

[meyergru]

Yes, that fixes it.

But it is not in 26.1 final, so for now you need:

Code Select Expand

opnsense-patch -c plugins 4212ffea8c2c
configctl webgui restart


[franco]

There will probably be a .1 next week for OpenSSL...