Looking for testers Q-Feeds plugin

Started by Q-Feeds, October 01, 2025, 08:43:40 PM

Previous topic - Next topic
Quote from: franco on October 22, 2025, 09:30:13 PMThis is the new maximum default since 25.7.5. It's calculating now based on available RAM.

Yep. My point was rather that the test was quirky:

$cnf = Config::getInstance()->object();
        if (!empty($cnf->system->maximumtableentries) && $cnf->system->maximumtableentries >= 2000000) {

There are 2 things I want to give feedback on and please forgive my ignorance since I don't know the internals.

So this cnf object holds all the settings. Of course cnf->system->maximumtableentries is empty, since nothing is set. How do I get the effective value. e.g. the UI shows that my system uses 10000000 so that info must be available.

For a proper test the above code shouldn't test for !empty &&, but check_effective_value(maximumtableentries) > 2000000 ||

Quote from: Q-Feeds on October 22, 2025, 09:52:43 PMAah that's some leftover code from the beta  version. We've removed it from the code now all together. To clean it you can run these commands:

Thanks, that did it. I did not even have to restart the webgui.

I am not sure I follow though. Leftover? So the file was not in the code, but still in the package? Or did you remove it from the code, after 1.2 was released?

Quote from: tessus on October 22, 2025, 10:23:39 PM
Quote from: franco on October 22, 2025, 09:30:13 PMThis is the new maximum default since 25.7.5. It's calculating now based on available RAM.

Yep. My point was rather that the test was quirky:

$cnf = Config::getInstance()->object();
        if (!empty($cnf->system->maximumtableentries) && $cnf->system->maximumtableentries >= 2000000) {

There are 2 things I want to give feedback on and please forgive my ignorance since I don't know the internals.

So this cnf object holds all the settings. Of course cnf->system->maximumtableentries is empty, since nothing is set. How do I get the effective value. e.g. the UI shows that my system uses 10000000 so that info must be available.

For a proper test the above code shouldn't test for !empty &&, but check_effective_value(maximumtableentries) > 2000000 ||

Quote from: Q-Feeds on October 22, 2025, 09:52:43 PMAah that's some leftover code from the beta  version. We've removed it from the code now all together. To clean it you can run these commands:

Thanks, that did it. I did not even have to restart the webgui.

I am not sure I follow though. Leftover? So the file was not in the code, but still in the package? Or did you remove it from the code, after 1.2 was released?

That was indeed a possibility yet since during the development the standard changed so this became obsolete.

Glad that did it! And thanks for pointing it out!

No we removed it from the code with the 1.2 release. So only the users who had the previous packages installed, have this file on their machines, sorry for not cleaning it up correctly.

Your Threat Intelligence Partner  qfeeds.com

On the Opnsense dashboard, is the "Blocked" figure a rolling number over a period or will it increase infinitely?

If over a period, is that a setting somewhere?
Deciso DEC697