improving accessibility for screen reader users

[jfayre]

Hello,
I am a totally blind user of Opnsense and use a screen reader.
I've found several accessibility issues in the web UI that make using Opnsense extremely difficult.
In looking at the code, some of these issues would be extremely easy to fix. The major issues include
1. using aria-hidden = "true" on dialogs and other controls. This makes them effectively invisible to a screen reader, but does nothing to actually hide the dialog visually.
2. unlabeled buttons: several buttons only use the Title attribute, which does not allow a screen reader to read the button label in most cases.

I would be willing to submit a PR to fix at least some of these.
I see there are a couple closed issues regarding accessibility.
First off, is someone already working on this? I know of at least one other blind user who is experiencing these issues and may be willing to help.
If not, I have a question about submitting a PR. If I'm modifying several files, should I submit everything in one PR, or do one PR per file or UI issue?

[tuto2]

Hi there,

I'm not aware of anyone working on this. If you could take a stab at it that'd be great. You don't have to submit a PR for every file, the PR should be limited to a single subject that the changes are trying to address, which may include multiple files.

That being said, if the PR is large, make sure you limit yourself to only the markup attributes (such as aria-hidden etc.) and don't introduce large changes in logic that need proper vetting - these should be submitted in a more isolated manner.

Cheers,
Stephan

[jfayre]

I submitted a PR to start this process a few days ago. Can someone take a look? There is a lot more to do, just want to make sure I'm not missing anything before I submit larger pull requests.
https://github.com/opnsense/core/pull/7543