Missing Traffic Data

[BertQuodge]

Hi

I'm new to OPNSense and to this forum so firstly hello & thanks for a great system!

I have installed  OPNsense 24.1.5_1-amd64 on a Protectli Vault Pro VP2420-4 Port PC. I have 2 WAN connections that I'm load balancing between between and all is working well from a firewall point of view. The WAN connections are provided to me as separate ethernet connections on 2 subnets with private 192.168.x.x/24 ip connections (this might be relevant, not sure!).

If I navigate to the Reporting/traffic page I can see graphs of the "in" and "out" data on LAN and WAN interfaces working correctly with real data. On the same page the "Top Hosts" in and out graphs are also displayed but without any data being shown. If I navigate to the "Top Talkers" tab no host data is displayed there either.

I've check the fw's backend log and I can see the error message below, from the configd.py process, when navigate to Reporting/Traffic:

Code: [Select]

Script action failed with Command '/usr/local/opnsense/scripts/interfaces/traffic_top.py --interfaces 'igc0'' returned non-zero exit status 1. at Traceback (most recent call last): File "/usr/local/opnsense/service/modules/actions/script_output.py", line 44, in execute subprocess.check_call(script_command, env=self.config_environment, shell=True, File "/usr/local/lib/python3.9/subprocess.py", line 373, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '/usr/local/opnsense/scripts/interfaces/traffic_top.py --interfaces 'igc0'' returned non-zero exit status 1.
If I then navigate to Top talkers I also see the same error in the backend log as above.

I don't know if this helps but if I run the command from the log via ssh:

/usr/local/opnsense/scripts/interfaces/traffic_top.py --interfaces 'igc0'

I receive this error message:

Code: [Select]

Traceback (most recent call last):
  File "/usr/local/opnsense/scripts/interfaces/traffic_top.py", line 154, in <module>
    if ip.is_private():
AttributeError: 'IPAddress' object has no attribute 'is_private'

Interface igc0 is the fw's LAN interface and is passing LAN traffic ok. I'm using igc0 as a dot1q trunk.

Any ideas on how I could fix the issue above will be appreciated! As above, I'm new to OPNsense so user error on my part is a likely cause!

Thanks

[franco]

https://github.com/opnsense/core/commit/0d7b9fd34f4a

# opnsense-patch 0d7b9fd34f4a

[BertQuodge]

Brilliant, many thanks!!

[franco]

I'll push a hotfix in a minute. It's not mission critical but I'd like to avoid numerous reports over the next week.

is_private() was only used once in the code so this was really really hard to spot. The people on Reddit were the quickest to report this actually. Quite interesting and helpful.


Cheers,
Franco

[BertQuodge]

Patch applied, all working well now!

Many thanks for your help and support.

[tekkyguy]

Thanks… works now!

Great works.