Duplicate and growing number of entries in Universal Plug and Play: Status

[franco]

I tried to update to 2.3.6 but of course the custom patching in FreeBSD ports for pf breaks the build of the new version. I guess this is as good as it gets.


Cheers,
Franco

[xpendable]

Well I created a freebsd bugzilla account and commented on bug 277226. Not sure if it will make a difference, but I figure the more noise that is made... the more likely it will be fixed

[franco]

Appreciate your help!

[AlpAne]

Hey guys,

I'm quite new to OPNsense and my setup with three PC:s and two Xbox consoles depends on UPNP to work, especially Call of Duty: Warzone.

Why can't the new version 2.3.6 that resolves the problem introduced with OPNsense 24.1 be included in easily so we can update the plugin and get a working UPNP-function again? I believe I don't understand the dependencies between FreeBSD versions, miniupnd versions and how they are implemented within OPNsense?

Please try to oversee my lack of knowledge on the internals and try to give a easy to understand explanation.

[franco]

FreeBSD introduced custom code patches into their port that now requires rewriting.


Cheers,
Franco

[AlpAne]

Is it in OPNsense or miniupnp the rewriting needs to be done? Is there any preliminary time plan when this can be implemented?

[xpendable]

OPNsense uses the FreeBSD port of miniupnpd, it is the FreeBSD port maintainers that need to update the package.

Link to the FreeBSD port of miniupnpd:
https://www.freshports.org/net/miniupnpd/

Link to the FreeBSD bugzilla for this issue:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277226

[AlpAne]

I have also bumped this issue at the FreeBSD bugzilla. Is there anything else we can do to push to get this issue resolved as soon as possible?

[AhnHEL]

Does this not affect anyone using vanilla FreeBSD?  Seems to be no incentive in updating the port even though miniupnpd has been updated 3 times since the last port was updated a year ago. 

[franco]

I assume the only prominent consumers are pfSense and OPNsense. Everybody running a simple FreeBSD setup can work around it

[AhnHEL]

Is this the same problem in pfSense?  Seems Mr. Provost is pretty active over there, hmmmmm.


https://redmine.pfsense.org/issues/15470

[AlpAne]

Seems like the same problem to me but I could be wrong? If it's fixed in pfSense why can't it be fixed in OPNsense?

[franco]

You mean fixed in pfSense only in a "FreeBSD-ports" repository by a FreeBSD committer?

"I've updated miniupnpd to the latest version and adjusted the libpfctl patch in https://gitlab.netgate.com/pfSense/FreeBSD-ports/-/commit/6e7d96166c051915155356546474a1c6e68cf2aa
That fixes the lack of expiring entries."

As of right now I don't see it in the actual FreeBSD ports and the FreeBSD ports upstream report is unattended. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277226

Apparently you can find the patch here

https://github.com/pfsense/FreeBSD-ports/commit/6e7d96166c051

What makes me wonder is why pfSense only saw this bug 20 days ago and fixed it in 2 days, but the upstream report has been open since February. You'd think a number of pfSense users would have been affected by that more than 20 days ago. That there doesn't seem to be incentive to hurry the fix into FreeBSD ports is just icing on the cake. Yummy.


Cheers,
Franco

[xpendable]

Ya seems to be some favoritism here, I left a new comment on the FreeBSD bugzilla questioning this exact thing. Probably end up getting deleted if they really are playing favorites 

[franco]

I can throw the patch into bugzilla and call maintainer timeout later this evening, but I have the feeling we're still missing a maintainer who will commit (and/or not ignore) this.

Think of all the reports of users suffering from this problem so far. If it weren't for the libpfctl complications that were introduced by the party who finally fixed it I'd have submitted an update for 2.3.6 already. You can see this was a non-trivial binary change from the patch and has no relation to upstream in the first place.

I'm even struggling to explain the magnitude of the situation bordering to the unbelievable, which would still have been solvable if the author had cared a month or two ago.


Cheers,
Franco