Broadcom P225P driver - vlans no longer work

[Thomas Niedermeier]

We did some further tests and the tests so far went well.
We already did some tests with ping and currently we are currently running iperf3 tests.
No issues so far. We are not done yet, but I wanted to keep you updated.

I also don't have much doubt about shipping this patch with a future kernel, would be great.

Cheers,
Thomas

[franco]

It landed in FreeBSD main branch and I've also queued it up for next kernel in 23.7.x unless you tell me I should remove it.


Cheers,
Franco

[rm@kdv]

It landed in FreeBSD main branch and I've also queued it up for next kernel in 23.7.x unless you tell me I should remove it.


Cheers,
Franco

Thats really good to hear. I have a (hopefully simple) question regarding upgrading to this:

I have a hardware installation with only affected NICs which leads to a broken system once upgrading to 23.7. How do I upgrade from 23.1.11_1 directly to a minor version containing the fixed kernel? or will there be a fixed 23.7 base kernel the 23.7 upgrade will use, that can be further upgraded to 23.7.x?

Regards,
Rudolf

[franco]

The situation is a bit tricky here. I'd recommend staying on 23.1.x until 23.7.x is fixed. I think it's going to be 23.7.4 which is a little longer, but once that happens I can move the 23.1.11 upgrade to 23.7.4 directly so people don't run into it.

And for full context: 23.7.3 is this week but will not offer a new kernel for other reasons.


Cheers,
Franco

[Werner Fischer]

Hi Franco,

I think there is an important comment here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269133#c47 with a commit that should be maybe included in 23.7.4, too:

bnxt: Don't restart on VLAN changes
In rS360398, a new iflib device method was added with default of opt out
for VLAN events needing an interface reset.

This is unintentional for bnxt(4) and is causing another bug in its VLAN
initialization code to affect the common case of adding and removing
VLANs on an existing interface.

What do you think?
Best regards, Werner

[franco]

Same commit for stable/13. I already have it on our stable/23.7 and will release this week. Likely on Thursday.


Cheers,
Franco

[rm@kdv]

Same commit for stable/13. I already have it on our stable/23.7 and will release this week. Likely on Thursday.


Cheers,
Franco

Is the direct upgrade path from 23.1 to 23.7 on systems with only affected NICs now fixed as well? or is there anything to note or do for a successful upgrade to 23.7.4+ ?

[rm@kdv]

Same commit for stable/13. I already have it on our stable/23.7 and will release this week. Likely on Thursday.


Cheers,
Franco

Is the direct upgrade path from 23.1 to 23.7 on systems with only affected NICs now fixed as well? or is there anything to note or do for a successful upgrade to 23.7.4+ ?

To answer my own question: Yes it fixed, upon upgrading to 23.7 it will directly upgrade to 23.7.5

[franco]

Sorry I was not in the office last week. Indeed we previously fixed the kernel due to this issue on upgrades and yesterday I changed the whole upgrade path to 23.7.5 (base and kernel being at 23.7.4 which is correct).


Cheers,
Franco