Contributing to Core/Trust

[iscons]

Hey guys, I hope Im at the right place for this.

As a relatively recent migrator to OPNsense I was missing some features and goodies in the Trust/Certificate functionality.
While looking at the source code I noticed that the functionality is implemented "pre Phalcon" and barely maintainable. So im currently planning to migrate the Trust funcionality to Phalcon/PHPSeclib.

Are these kind of contributions (to the Core) welcome or should I aim for an installable Plugin?

[franco]

Hi,

Take a look at the work that Manuel did on this front:

https://github.com/opnsense/core/pull/5483

We'd like to have that eventually but the issue is that at least the same amount of review and audit needs to take place before we can switch such a vital part from static code to MVC.

However, we don't mind a bit of review and questions to specific things in this PR or what parts to "modernise" before going the MVC route.

This will land on a roadmap at some point, but it could be years away still depending on funding and customer interest. We get that it should be open source but we can't sponsor this work ourselves fully.

First things first maybe you can assess how workable Manuel's proposal is from your point of view and then start a discussion on that PR on how we could proceed. If we can find small enough steps something (MVP) might be ready for 23.1 but I don't want to make promises I can't keep.


Cheers,
Franco