HAproxy php error after upgrade 22.1 to 22.7

[deeler]

the services/HAproxy page is inaccessible and throwing errors
Also the HAproxy itself isn't working (although the dashboard lobby shows the service running)

some of the debug messages:

Code: [Select]

[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $expression follows optional parameter $description in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 147
[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $testType follows optional parameter $description in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 176
[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $type follows optional parameter $description in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 176
[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $address follows optional parameter $description in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 204
[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $port follows optional parameter $description in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 204
[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $mode follows optional parameter $description in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 204
[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $name follows optional parameter $enabled in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 230
[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $mode follows optional parameter $enabled in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 230
[29-Jul-2022 07:36:15 Europe/Brussels] PHP Deprecated:  Required parameter $algorithm follows optional parameter $enabled in /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php on line 230
[29-Jul-2022 07:36:15 Europe/Brussels] Exception: Error at /usr/local/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.php:147 - Required parameter $expression follows optional parameter $description (errno=8192) in /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php:159
Stack trace:
#0 [internal function]: OPNsense\Base\ApiControllerBase->APIErrorHandler(8192, 'Required parame...', '/usr/local/opns...', 147)
#1 [internal function]: Phalcon\Autoload\Loader->requireFile('/usr/local/opns...')
#2 [internal function]: Phalcon\Autoload\Loader->autoloadCheckDirectories(Array, 'OPNsense\\HAProx...', true)
#3 [internal function]: Phalcon\Autoload\Loader->autoload('OPNsense\\HAProx...')
#4 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php(174): ReflectionClass->__construct('\\OPNsense\\HAPro...')
#5 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php(163): OPNsense\Base\ApiMutableModelControllerBase->getModel()
#6 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php(151): OPNsense\Base\ApiMutableModelControllerBase->getModelNodes()
#7 [internal function]: OPNsense\Base\ApiMutableModelControllerBase->getAction()
#8 [internal function]: Phalcon\Dispatcher\AbstractDispatcher->callActionMethod(Object(OPNsense\HAProxy\Api\SettingsController), 'getAction', Array)
#9 [internal function]: Phalcon\Dispatcher\AbstractDispatcher->dispatch()
#10 /usr/local/opnsense/www/api.php(26): Phalcon\Mvc\Application->handle('/api/haproxy/se...')
#11 {main}

[franco]

Can you try this patch? https://github.com/opnsense/core/commit/38021c30

# opnsense-patch 38021c30


Cheers,
Franco

[astrandb]

Patch works fine for me.

[franco]

Splendid, thanks!

We'll be preparing a hotfix shortly. 2 of 4 reported issues have been taken care of now.


Cheers,
Franco

[deeler]

thanks! patch works fine.
looking forward to the hotfix ...
good work!

[deeler]

hotfix installed! works

thanks for the quick fix!!