New traffic widget broken in Firefox

[FullyBorked]

Looks like the new traffic widget in 21.1.2 look like it isn't working in Firefox for some reason.  Seems to work ok in other browsers, anyone else seeing this or is it just something in my specific Firefox?

[sandrzej]

Broken in Chrome. Works in Edge .

[FullyBorked]

Broken in Chrome. Works in Edge .

Wow that looks goofy.  Mine are just blank in firefox.  My Chrome doesn't look all janky like that.  Really strange.

Sent from my IN2025 using Tapatalk

[priller]

Broken in Chrome. Works in Edge .

I get the same on Chrome (Mac).  It also "flutters" insanely until the initial timeline run completes.

[cguilford]

Mine are blank in Ffox as well.

[atom]

For me, it looks fine under both Edge and Firefox.

[IsaacFL]

Same here (see attached), Firefox on Windows and Ubuntu does not show the graph. Just blank spot.

Windows - Edge Chrome works fine.  Windows old Edge looks like the Firefox. I don't have Google Chrome, so haven't tried it.

Someone said that Firefox on Mac is ok, though.

[sandrzej]

Update:  in firefox Windows 10 traffic widget blank

[franco]

https://github.com/opnsense/core/commit/8b9764fa86

# opnsense-patch 8b9764fa86

On a sadder note: no bugs related to this raised in the issue tracker so far...


Cheers,
Franco

[FullyBorked]

https://github.com/opnsense/core/commit/8b9764fa86

# opnsense-patch 8b9764fa86

On a sadder note: no bugs related to this raised in the issue tracker so far...


Cheers,
Franco

I don't have a github account but I guess I can  create one to report a bug, if that's helpful .

[franco]

That's always appreciated, thanks in advance!

[FullyBorked]

That's always appreciated, thanks in advance!

Done. https://github.com/opnsense/core/issues/4750

[Fright]

@franco

https://github.com/opnsense/core/commit/8b9764fa86

it's weird. I thought its "$( document ).ready" issue. not 'load'

hm. sorry, is really can be called twice

when I made this PR (https://github.com/opnsense/core/pull/4552), I thought that it would be great to have a custom event and start fetching data after arranging the widgets

[Fright]

for empty widget on Firefox: somehow canvas gets height: 0 on chart init if widget called on "load".
works good with $( document ).ready for me

[franco]

The widgets have a lot of old JS code that should be reworked, but I think we will not open this can of worms until 21.7 is out due to other priorities. Another issue is that some widgets do not automatically reload and basically all of them do manual code for the same purposes duplicating code where it shouldn't be necessary.

As said I like your rewrite, but we should just write replacements instead of changing the code to something completely else in existing widgets.

I will talk to Ad about integrating your PR or at least do the review to see what will happen with it.


Cheers,
Franco