OPNsense
  • Home
  • Help
  • Search
  • Login
  • Register

  • OPNsense Forum »
  • English Forums »
  • Development and Code Review (Moderator: fabian) »
  • Theme Tukan - edited version
« previous next »
  • Print
Pages: 1 [2] 3

Author Topic: Theme Tukan - edited version  (Read 12033 times)

chemlud

  • Hero Member
  • *****
  • Posts: 2488
  • Karma: 112
    • View Profile
Re: Theme Tukan - edited version
« Reply #15 on: February 25, 2021, 09:49:31 am »
See first attachment, a short list of rules.

Now I disabeled the second (!) rule, and before pressing "Apply" it looks (icon color) as if it is already disabled (attachment 2). With a short list like this it might look like a minor problem, with longer lists and if you want to turn off 2-3 rules it really becomes a problem, especially as after changing the FIRSt rule the "You will have to press APPLY" message changes the screen layout (scrolling down the rules).
« Last Edit: February 25, 2021, 09:51:42 am by chemlud »
Logged
kind regards
chemlud
____
"The price of reliability is the pursuit of the utmost simplicity."
C.A.R. Hoare

felix eichhorns premium katzenfutter mit der extraportion energie

A router is not a switch - A router is not a switch - A router is not a switch - A rou....

opnsenseuser

  • Sr. Member
  • ****
  • Posts: 437
  • Karma: 70
    • View Profile
Re: Theme Tukan - edited version
« Reply #16 on: February 25, 2021, 09:55:29 am »
I think this is a Rebellion-theme Problem. I forwarded this to Martin.
Logged
Supermicro A2SDi-4C-HLN4F
Team Rebellion Member (sidebar / themes: tukan, cicada & vicuna)

opnsenseuser

  • Sr. Member
  • ****
  • Posts: 437
  • Karma: 70
    • View Profile
Re: Theme Tukan - edited version
« Reply #17 on: February 25, 2021, 09:57:33 am »
I forwarded this to Martin, but his Mailbox is Full. :-(
Logged
Supermicro A2SDi-4C-HLN4F
Team Rebellion Member (sidebar / themes: tukan, cicada & vicuna)

chemlud

  • Hero Member
  • *****
  • Posts: 2488
  • Karma: 112
    • View Profile
Re: Theme Tukan - edited version
« Reply #18 on: February 25, 2021, 10:00:05 am »
Quote from: opnsenseuser on February 25, 2021, 09:57:33 am
I forwarded this to Martin, but his Mailbox is Full. :-(

:-D

Just test it with your themes, I found it difficult with different themes ;-)

Isn't there a way to kind of "grey-out" rules that are REALLY inactive?
Logged
kind regards
chemlud
____
"The price of reliability is the pursuit of the utmost simplicity."
C.A.R. Hoare

felix eichhorns premium katzenfutter mit der extraportion energie

A router is not a switch - A router is not a switch - A router is not a switch - A rou....

opnsenseuser

  • Sr. Member
  • ****
  • Posts: 437
  • Karma: 70
    • View Profile
Re: Theme Tukan - edited version
« Reply #19 on: February 25, 2021, 02:02:53 pm »
Quote from: chemlud on February 25, 2021, 10:00:05 am
Quote from: opnsenseuser on February 25, 2021, 09:57:33 am
I forwarded this to Martin, but his Mailbox is Full. :-(

:-D

Just test it with your themes, I found it difficult with different themes ;-)

Isn't there a way to kind of "grey-out" rules that are REALLY inactive?

can you draw your idea in the picture for me?
The rules which are disabled are in cicada and vicuna yellow. Do you think grey is bettet for a dark theme?

I like to be convinced. every solution that is better is taken.
« Last Edit: February 25, 2021, 03:03:32 pm by opnsenseuser »
Logged
Supermicro A2SDi-4C-HLN4F
Team Rebellion Member (sidebar / themes: tukan, cicada & vicuna)

Fright

  • Hero Member
  • *****
  • Posts: 1777
  • Karma: 164
    • View Profile
Re: Theme Tukan - edited version
« Reply #20 on: February 25, 2021, 07:43:24 pm »
sorry, if I understood @chemlud correctly, he wants the rows with the rules disabled and written to the config to be somehow different from the rows with the rules that were just disabled but not written to the config yet.
may be its possible via:
tr.rule.text-muted {
    background-color: darkgray;
}
or some
but it seems to me this will only add unnecessary variegation to the table
Tukan is the most eye-friendly theme imho
that's why I asked not to make the left panel so contrast  ;)
Logged

chemlud

  • Hero Member
  • *****
  • Posts: 2488
  • Karma: 112
    • View Profile
Re: Theme Tukan - edited version
« Reply #21 on: February 25, 2021, 07:52:58 pm »
@opnsenseuser: the "(disabled)" is an option.

Would love to see the option @Fright proposed as a draft... ;-)
Logged
kind regards
chemlud
____
"The price of reliability is the pursuit of the utmost simplicity."
C.A.R. Hoare

felix eichhorns premium katzenfutter mit der extraportion energie

A router is not a switch - A router is not a switch - A router is not a switch - A rou....

opnsenseuser

  • Sr. Member
  • ****
  • Posts: 437
  • Karma: 70
    • View Profile
Re: Theme Tukan - edited version
« Reply #22 on: February 26, 2021, 02:34:16 pm »
Quote from: chemlud on February 25, 2021, 07:52:58 pm
@opnsenseuser: the "(disabled)" is an option.

Would love to see the option @Fright proposed as a draft... ;-)

Thats a Good idea. But there has to be a Note at the bottom like the rule Icon Description therefore, so everybody knows what that means. And this description has to be done in the Core source.
« Last Edit: February 26, 2021, 02:50:50 pm by opnsenseuser »
Logged
Supermicro A2SDi-4C-HLN4F
Team Rebellion Member (sidebar / themes: tukan, cicada & vicuna)

opnsenseuser

  • Sr. Member
  • ****
  • Posts: 437
  • Karma: 70
    • View Profile
Re: Theme Tukan - edited version
« Reply #23 on: February 26, 2021, 05:22:51 pm »
my idea would not have been to mark the entire line but only the words except the first column and the last column because of the icons.
thus an additional note about what the gray line means would also be omitted.

first example is red and second is black (you can make the colors even better visible by choosing another color or a brighter one )

« Last Edit: February 26, 2021, 05:30:15 pm by opnsenseuser »
Logged
Supermicro A2SDi-4C-HLN4F
Team Rebellion Member (sidebar / themes: tukan, cicada & vicuna)

chemlud

  • Hero Member
  • *****
  • Posts: 2488
  • Karma: 112
    • View Profile
Re: Theme Tukan - edited version
« Reply #24 on: February 26, 2021, 08:08:33 pm »
 strike font in red definitely an option. This is the appearance AFTER disaableing, but BEFORE pressing "Apply", correct? :-)
Logged
kind regards
chemlud
____
"The price of reliability is the pursuit of the utmost simplicity."
C.A.R. Hoare

felix eichhorns premium katzenfutter mit der extraportion energie

A router is not a switch - A router is not a switch - A router is not a switch - A rou....

opnsenseuser

  • Sr. Member
  • ****
  • Posts: 437
  • Karma: 70
    • View Profile
Re: Theme Tukan - edited version
« Reply #25 on: February 26, 2021, 10:33:49 pm »
Quote from: chemlud on February 26, 2021, 08:08:33 pm
strike font in red definitely an option. This is the appearance AFTER disaableing, but BEFORE pressing "Apply", correct? :-)

No, it has to be applied first to see this in the rule section.

Disable the nat rules shows the line before applying. so it is a Core sourcecode code thing
« Last Edit: February 27, 2021, 05:12:19 pm by opnsenseuser »
Logged
Supermicro A2SDi-4C-HLN4F
Team Rebellion Member (sidebar / themes: tukan, cicada & vicuna)

opnsenseuser

  • Sr. Member
  • ****
  • Posts: 437
  • Karma: 70
    • View Profile
Re: Theme Tukan - edited version
« Reply #26 on: February 27, 2021, 12:29:01 am »
Quote from: chemlud on February 26, 2021, 08:08:33 pm
strike font in red definitely an option. This is the appearance AFTER disaableing, but BEFORE pressing "Apply", correct? :-)

i did a pull request and uploaded a lot of screenshots. i think it looks nice!
https://github.com/opnsense/plugins/pull/2249
Logged
Supermicro A2SDi-4C-HLN4F
Team Rebellion Member (sidebar / themes: tukan, cicada & vicuna)

Fright

  • Hero Member
  • *****
  • Posts: 1777
  • Karma: 164
    • View Profile
Re: Theme Tukan - edited version
« Reply #27 on: February 27, 2021, 06:33:17 pm »
another wild idea for toggled-not-applied rules: what if we just start to rotate toggle icon? (of course it will work only until you refresh page by applying changes or manually)
no themes updates needed
Logged

opnsenseuser

  • Sr. Member
  • ****
  • Posts: 437
  • Karma: 70
    • View Profile
Re: Theme Tukan - edited version
« Reply #28 on: February 27, 2021, 07:34:13 pm »
Quote from: Fright on February 27, 2021, 06:33:17 pm
another wild idea for toggled-not-applied rules: what if we just start to rotate toggle icon? (of course it will work only until you refresh page by applying changes or manually)
no themes updates needed

I think your idea is also very good. I've now solved it with crossed out. Let's see how it works when you work with it.
Logged
Supermicro A2SDi-4C-HLN4F
Team Rebellion Member (sidebar / themes: tukan, cicada & vicuna)

Fright

  • Hero Member
  • *****
  • Posts: 1777
  • Karma: 164
    • View Profile
Re: Theme Tukan - edited version
« Reply #29 on: February 27, 2021, 08:14:30 pm »
something like
https://github.com/kulikov-a/rules/issues/1
Logged

  • Print
Pages: 1 [2] 3
« previous next »
  • OPNsense Forum »
  • English Forums »
  • Development and Code Review (Moderator: fabian) »
  • Theme Tukan - edited version
 

OPNsense is an OSS project © Deciso B.V. 2015 - 2024 All rights reserved
  • SMF 2.0.19 | SMF © 2021, Simple Machines
    Privacy Policy
    | XHTML | RSS | WAP2