Home
Help
Search
Login
Register
OPNsense Forum
»
Archive
»
20.7 Legacy Series
»
Dashboard: CPU usage graph style
« previous
next »
Print
Pages: [
1
]
Author
Topic: Dashboard: CPU usage graph style (Read 5299 times)
tofaz
Jr. Member
Posts: 58
Karma: 4
Dashboard: CPU usage graph style
«
on:
November 10, 2020, 05:16:30 pm »
Hi all,
this is mainly a personal/cosmetic taste and I just wanted to know what do you think about changing the CPU usage graph in the dashboard to be the same as the one for State table size/MBUF Usage/Memory usage/Disk usage?
Beside being the same style I think the bars provide more detailed view, always showing the percentage value of the usage.
Thank you,
tofaz
Logged
tofaz
Jr. Member
Posts: 58
Karma: 4
Re: Dashboard: CPU usage graph style
«
Reply #1 on:
November 23, 2020, 06:22:17 am »
up
Logged
Ricardo
Full Member
Posts: 233
Karma: 12
Re: Dashboard: CPU usage graph style
«
Reply #2 on:
November 23, 2020, 11:03:29 am »
Open feature request here:
https://github.com/opnsense/core/issues
otherwise very low probability it will be even responded to (even if you open feature request, that means 0 guarantee, and your request remains low popularity, set your expectations accordingly, don't expect resolution in 2-3 years, yes years)
Logged
Fright
Hero Member
Posts: 1777
Karma: 164
Re: Dashboard: CPU usage graph style
«
Reply #3 on:
November 23, 2020, 02:32:36 pm »
@Ricardo
I think it can be faster. Make changes in widget php and PR )
@tofaz
imho chart makes sense: it shows some history of cpu load.
may be better to
add
a progress bar. and leave the chart as is?
«
Last Edit: November 23, 2020, 02:46:20 pm by Fright
»
Logged
Fright
Hero Member
Posts: 1777
Karma: 164
Re: Dashboard: CPU usage graph style
«
Reply #4 on:
November 23, 2020, 04:00:44 pm »
something like this?
It makes sense?
«
Last Edit: November 24, 2020, 11:24:25 am by Fright
»
Logged
tofaz
Jr. Member
Posts: 58
Karma: 4
Re: Dashboard: CPU usage graph style
«
Reply #5 on:
November 23, 2020, 05:38:12 pm »
This looks good to me! In my personal case if I need more historical CPU data I would go straight to the CPU usage graph, otherwise I just need the current snapshot once I'm on the dashboard.
My post aimed to gather opinions from users/devs prior to post a PR as it's not really a "must" change.
Logged
Fright
Hero Member
Posts: 1777
Karma: 164
Re: Dashboard: CPU usage graph style
«
Reply #6 on:
November 23, 2020, 05:58:55 pm »
these are very simple changes (only 10 lines in one file), so all that remains is to convince the devs of the benefits of this.
for me as a user, this does not add much benefit, but it does not bother me either.
I can attach a widget php-file if you want to use the forum link in your FR (if you will)
Logged
tofaz
Jr. Member
Posts: 58
Karma: 4
Re: Dashboard: CPU usage graph style
«
Reply #7 on:
November 23, 2020, 08:49:55 pm »
That would be great! Thank you very much!
Logged
Fright
Hero Member
Posts: 1777
Karma: 164
Re: Dashboard: CPU usage graph style
«
Reply #8 on:
November 24, 2020, 06:07:38 am »
just one question. maybe this one? even less code, no extra progress-bar, there is already room for these at chart name column
widget file attached (added strings 49,50; string 190 modified)
--
version with progress-bar attached to the post with progress-bar image
(strings added: 49-52;215-223)
«
Last Edit: November 24, 2020, 11:26:48 am by Fright
»
Logged
tofaz
Jr. Member
Posts: 58
Karma: 4
Re: Dashboard: CPU usage graph style
«
Reply #9 on:
November 24, 2020, 05:16:18 pm »
The progress bar is the one appealing to me. But not sure about other users.
Logged
tofaz
Jr. Member
Posts: 58
Karma: 4
Re: Dashboard: CPU usage graph style
«
Reply #10 on:
November 24, 2020, 08:54:43 pm »
Feature request created:
https://github.com/opnsense/core/issues/4480
Thank you Fright for your effort/help!
Logged
Fright
Hero Member
Posts: 1777
Karma: 164
Re: Dashboard: CPU usage graph style
«
Reply #11 on:
November 25, 2020, 03:48:14 pm »
@AdSchellevis has already added changes!
can wait for release or apply patch
Code:
[Select]
opnsense-patch 235ef7f
«
Last Edit: November 25, 2020, 05:01:58 pm by Fright
»
Logged
Print
Pages: [
1
]
« previous
next »
OPNsense Forum
»
Archive
»
20.7 Legacy Series
»
Dashboard: CPU usage graph style