[SOLVED] A bug in 26.7.9_1 with alias edit from firewall rule.

[Nullman]

Clicking on edit alias on a firewall rule doesnt work in both 26.7.9 and 26.7.9_1. When i click on edit alias, it brings Firewall/Aliases page, but it doesnt pop up the edit window. Instead, i have to manually locate the alias and click edit pencil to make changes. Tested on latest version of Firefox and Google Chrome.

[oc]

Thanks for reporting this, @Nullman. I noticed the same today (coincidentally, I have tweaked my aliases over the last few days, and I have updated to 26.7.9 yesterday, and to 26.7.9_1 today - so I observed something feels different).

It would be very practical if this was reverted to what worked previously.

Thanks :)
OC

[franco]

Can someone make a video of this please. There have been some loosely related reports to the alias page behaving weird but not on your end.


Cheers,
Franco

[Greelan]

I don't have a video, but same here on 26.7.9, every time and in any browser.

The rule page links to /ui/firewall/alias/index/<name>. The alias page then opens the editor by copying the first edit button in the grid and clicking the copy (alias.volt, the "Open form with alias selected" block).

26.7.9 changed the grid ("ui: delegate bootgrid cell handlers") so the click handler sits on the table cell, not on the button. The copied button isn't inside a cell, so clicking it does nothing.

Calling the grid's edit function directly fixes it for me. In place of the clone and click (the setTimeout can go too):

Code Select Expand

$("#grid-aliases").bootgrid('command_edit', null, null, data.uuid);

[Monviech (Cedrik)]

One could pretty much also use this most likely now as well its the canonical way:

https://github.com/opnsense/core/blob/855dbea44aef4b88712b6e4008998a8fa6d0d697/src/opnsense/www/js/opnsense_ui.js#L1282

[Greelan]

I'm all for the canonical way :)

[franco]

The alias page probably has a bit of historical baggage being one of the earlier components:

community/19.1/19.1:o fully functional firewall alias API

EDIT: looks like I'm talking about something else entirely, please disregard.

[tuto2]

One could pretty much also use this most likely now as well its the canonical way:

https://github.com/opnsense/core/blob/855dbea44aef4b88712b6e4008998a8fa6d0d697/src/opnsense/www/js/opnsense_ui.js#L1282

Great minds think alike ;)

Should be fixed with https://github.com/opnsense/core/commit/6ad17c522c6a03ec6044bf855ae65cd6f343ab38

# opnsense-patch https://github.com/opnsense/core/commit/6ad17c522c6a03ec6044bf855ae65cd6f343ab38

The alias page probably has a bit of historical baggage being one of the earlier components:

This is true though, and the primary reason this broke in the first place.

Cheers,
Stephan

[Nullman]

Should be fixed with https://github.com/opnsense/core/commit/6ad17c522c6a03ec6044bf855ae65cd6f343ab38
# opnsense-patch https://github.com/opnsense/core/commit/6ad17c522c6a03ec6044bf855ae65cd6f343ab38

Thanks tuto2. This fixed it.