Improvement of CARP VIP creation GUI

[klosz007]

Hi,

I have just spent entire evening troubleshooting very weird issue which eventually turned out to be caused by improper CARP interface creation.
It could be easily avoided by improving GUI for CARP IP creation.

GUI asks for IP address but it must be provided together with netmask (e.g. 192.168.100/24) which should be same as (correction) underlying's interface netmask.

Problem is that if one provides just IP, CARP VIP gets created with single host /32 netmask. And that leads to weird issues - e.g. DHCP no longer works properly. And it is hard to notice that no netmask was provided.


I think there should be separate dropbox to pick up netmask length so that one cannot enter IP without a netmask.
Ideally if it self-suggested correct netmask for CARP or warned if selected netmask is different from the underlying interface.

Thanks !

[franco]

Hi,

We discussed this today and decided to make the specification of the netmask required instead of auto-adding it.

The complain on the legacy page was the same: 32 bit was not what the user wanted so forcing everyone to type is better than having an auto-selected value as dropdown or not. ;)


Cheers,
Franco

[klosz007]

Thanks a lot for taking my suggestion into consideration ! Everything will be better than silently adding /32 netmask when no netmask was provided. Dropbox with netmask length, checking if netmask was provided etc etc.

[franco]

Believe it or not the same complaint about "32" was made with the dropdown available... users said it was not what they wanted/expected. Making them actually type it is probably the best psychological approach. ;)


Cheers,
Franco

[franco]

PS: the backport for 23.7.x is https://github.com/opnsense/core/commit/1bfb673f09