Traffic graph widget not working anymore after 21.1.2 update

[QBANIN]

Now it works randomly every few Dashboard reloads (F5), but in most cases widget is empty.

hm. can not reproduce. any errors in browser console?

Code Select Expand

Uncaught TypeError: data is undefined
    <anonymous> https://192.168.10.1/index.php:2898
    complete https://192.168.10.1/ui/js/opnsense.js?v=a8833cf67460c892:242
    jQuery 6
    ajaxGet https://192.168.10.1/ui/js/opnsense.js?v=a8833cf67460c892:234
    <anonymous> https://192.168.10.1/index.php:2895
    jQuery 8
    <anonymous> https://192.168.10.1/index.php:1426
index.php:2898:17


[Fright]

Uncaught TypeError: data is undefined

this error can occur immediately after the page refresh (executed API requests are aborted and the firefox has time to throw an error. especially if you refresh the page again before it is fully loaded).
but all should work fine after this errors.
looks like an unpatched version for me
please can you swith to Inspector tab in the console and search for "widget.find" in "Search HTML" string? there should be 1 result

[QBANIN]

Uncaught TypeError: data is undefined

this error can occur immediately after the page refresh (executed API requests are aborted and the firefox has time to throw an error. especially if you refresh the page again before it is fully loaded).
but all should work fine after this errors.
looks like an unpatched version for me
please can you swith to Inspector tab in the console and search for "widget.find" in "Search HTML" string? there should be 1 result

This error show up no matter what is the refresh interval. In this case widget remains empty "forever".

There's no "widget.find" in inspector tab -> "Search HTML" -> result

[Fright]

There's no "widget.find"

if there's no "widget.find" in HTML then 4053952 not applied

[QBANIN]

There's no "widget.find"

if there's no "widget.find" in HTML then 4053952 not applied

I'm pretty sure it was...

Code Select Expand

root@OPNsense:/home/qba # opnsense-patch 4053952
Found local copy of 4053952, skipping fetch.
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|From 405395264ffb4f77e298a3bfa5d670b9a53eeda6 Mon Sep 17 00:00:00 2001
|From: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
|Date: Mon, 8 Mar 2021 21:45:00 +0300
|Subject: [PATCH] index.php: strip scripts from widgets before move (#4752)
|
|---
| src/www/index.php | 3 +++
| 1 file changed, 3 insertions(+)
|
|diff --git a/src/www/index.php b/src/www/index.php
|index 6663799e70..dd6abb0241 100644
|--- a/src/www/index.php
|+++ b/src/www/index.php
--------------------------
Patching file www/index.php using Plan A...
Reversed (or previously applied) patch detected!  Assuming -R.Hunk #1 succeeded at 263.
done
All patches have been applied successfully.  Have a nice day.


Whis is what i got after running opnsense-patch 4053952 again...

[Fright]

Reversed (or previously applied) patch detected!

yes, looks like it was applied. but then definitely there should have been a "widget.find" when searching in html.
I'm trying very hard to reproduce this behavior on the patched version and nothing works for me.
so it looks like on this ticket? https://github.com/opnsense/core/issues/4750

[QBANIN]

Reversed (or previously applied) patch detected!

yes, looks like it was applied. but then definitely there should have been a "widget.find" when searching in html.
I'm trying very hard to reproduce this behavior on the patched version and nothing works for me.
so it looks like on this ticket? https://github.com/opnsense/core/issues/4750

Yes, same issue.

[Fright]

ah. i see. autocomplete will not show this. you need to type it and press enter )
can you apply this patch again please?
and i will try to reproduce the bug again

[QBANIN]

ah. i see. autocomplete will not show this. you need to type it and press enter )
can you apply this patch again please?
and i will try to reproduce the bug again

You were right. Here's the output with patch reapplied. For some reason FF doesn't let my copy as text...


P.S. Firefox 86.1.1@Android has the same issue.