LetsEncrypt Plugin - Request for hosting.de DNS Service

[amp]

Dear all,
i would like to issue Certificates with the LetsEncrypt Plugin. I am on 19.1.3 and the acme Plugin is in version 1.20.

The DNS Provider is hosting.de, and as we want to issue Wildcard Certs, we plan to use the DNS-01 Validation method.

The acme.sh project by NeilPang provides a script to the hosting.de API, but the plugin does not yet list it.

Would it be possible to add this to the list of available DNS Services: https://github.com/Neilpang/acme.sh/blob/master/dnsapi/dns_hostingde.sh
Looking forward to your replies.

Good Evening, Alexander

[franco]

Hi Alexander,

Indeed, it was added in acme.sh 2.8.0 not too long ago.

You can create a ticket at https://github.com/opnsense/plugins/issues or even better try to write the patch yourself with the help of a similar issue as a blueprint:

https://github.com/opnsense/plugins/pull/712/files

The maintainer Frank will be happy to review and merge the patch I'm sure.


Cheers,
Franco

[amp]

Thanks for the hint - I made the changes to the corresponding files on GitHub according to the mentioned blueprints and made a pull request which is now approved.

[franco]

And merged by Frank. 

I think this will be in 19.1.5 (not to be confused with 19.1.4 which is out tomorrow).


Cheers,
Franco

[amp]

Good Evening Franco,

does it make sense it i test the patch before? Correct me if i am wrong, but i just have to

#opnsense-patch -c plugins e4a7d97 (which is the correct commit number btw.)

to install the patch?

Best, Alexander

[franco]

Hi Alexander,

Yes, you can try it on a current 19.1.x with this command. But we like to assume it works as provided in the PR.


Cheers,
Franco