18.1.4 and 18.1.5 updates overwrite patch 7a823c56a

[Davesworld]

Patch 7a823c56a which is here github.com/opnsense/core/commit/7a823c56a and manually applied by invoking # opnsense-patch 7a823c56a which fixed a huge problem gets  removed with each update that replaces SNatRule.php. This is 18.1.5 is the second update that replaces SNatRule.php with the pre-patch version. Why isn't this fix permanently in SNatRule.php?

Edit: On a previous thread where the patch was introduced by Franco for me to try, Franco DID state that it will not be integrated until 18.1.6. The last two updates 18.1.4 and now 18.1.5 undid it by overwriting the patched file. I may reverse the patch just prior to 18.1.6 but should not matter at that point.

[franco]

As stated elsewhere: patches are removed on updates if they are not yet included in the latest release. They are mainly for testing and do not stick around to provoke latent issues later.


Cheers,
Franco

[Davesworld]

The last two updates also allowed me to confirm that this patch fixed the problem, as soon as the updates were applied, most of the streaming services and updates for various operating systems quit working, upon reapplying the patch, everything resumed working as they should.

I changed the title for more accuracy as it overwrites the file that the patch fixes, does not remove the patch itself.

I'm curious why a file that is not modified recently by the OPNsense Team would even be included in an update?

[franco]

I'm not sure what you are saying.

You are patching your live system OPNsense files with the patch. An update deletes and rewrites these files cleanly.

If you apply a patch and do a health audit under firmware it will tell you that patched files do not match the expected checksums.

If you remove the patch the same audit will tell you all files are ok.

Any package update will change the packaged files back to the expected state.


Cheers,
Franco