Monit - Service restarting options no longer valid in 26.1.11

[bucker00]

I've had Monit set up to watch Unbound forever and restart it if something happens.
I'd also like to get this going for the new Cloudflared plugin (you guys rock btw).

The Start and Stop commands no longer accept spaces - it used to.
The command for Start stored is '/usr/local/sbin/pluginctl -s unbound start' but trying to save this now returns 'Text may not contain spaces or tabs.' and the options do not save.   

Edit: The Service Tests section also now disallows spaces where they were previously allowed - in both the Name and Condition fields.  This renders pretty much any condition invalid.

[franco]

Hi,

I agree about what you said except for name, but maybe I'm missing something:

https://github.com/opnsense/core/blob/10a27499b31770521cfda524d1efecb2eb3fb3f1/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml#L185

# opnsense-patch https://github.com/opnsense/core/commit/b86fb9946

Unfortunately, the security design of monit is non-existent and in hindsight it should have never have been merged to core.


Cheers,
Franco

[bucker00]

Worded badly on my part about the Name field, definitely no need for spaces there but they were previously allowed was my point.
Thanks Franco - that's got it fixed, much appreciated!

[franco]

Hey,

I've tried 26.1.10 and I cannot add a space to the name so what I suspected is true.

If you find any other spots let me know.  This is hotfix material and will likely be addressed this afternoon.


Cheers,
Franco