Dashboard: CPU usage graph style

Started by tofaz, November 10, 2020, 05:16:30 PM

Previous topic - Next topic
Hi all,

this is mainly a personal/cosmetic taste and I just wanted to know what do you think about changing the CPU usage graph in the dashboard to be the same as the one for State table size/MBUF Usage/Memory usage/Disk usage?

Beside being the same style I think the bars provide more detailed view, always showing the percentage value of the usage.

Thank you,
tofaz


Open feature request here: https://github.com/opnsense/core/issues
otherwise very low probability it will be even responded to (even if you open feature request, that means 0 guarantee, and your request remains low popularity, set your expectations accordingly, don't expect resolution in 2-3 years, yes years)

November 23, 2020, 02:32:36 PM #3 Last Edit: November 23, 2020, 02:46:20 PM by Fright
@Ricardo
I think it can be faster. Make changes in widget php and PR )
@tofaz
imho chart makes sense: it shows some history of cpu load.
may be better to add a progress bar. and leave the chart as is?

November 23, 2020, 04:00:44 PM #4 Last Edit: November 24, 2020, 11:24:25 AM by Fright
something like this?
It makes sense?

This looks good to me! In my personal case if I need more historical CPU data I would go straight to the CPU usage graph, otherwise I just need the current snapshot once I'm on the dashboard.

My post aimed to gather opinions from users/devs prior to post a PR as it's not really a "must" change.

these are very simple changes (only 10 lines in one file), so all that remains is to convince the devs of the benefits of this.
for me as a user, this does not add much benefit, but it does not bother me either.
I can attach a widget php-file if you want to use the forum link in your FR (if you will)

That would be great! Thank you very much!

November 24, 2020, 06:07:38 AM #8 Last Edit: November 24, 2020, 11:26:48 AM by Fright
just one question. maybe this one? even less code, no extra progress-bar, there is already room for these at chart name column
widget file attached (added strings 49,50; string 190 modified)
--
version with progress-bar attached to the post with progress-bar image
(strings added: 49-52;215-223)

The progress bar is the one appealing to me. But not sure about other users.


November 25, 2020, 03:48:14 PM #11 Last Edit: November 25, 2020, 05:01:58 PM by Fright
@AdSchellevis has already added changes!
can wait for release or apply patch
opnsense-patch 235ef7f