Suggestion for LRO and TSO hardware offloading

Started by senser, August 11, 2020, 07:33:07 PM

Previous topic - Next topic
I suggest to change the description for those options from

QuoteChecking this option will disable hardware TCP segmentation offloading (TSO, TSO4, TSO6). This offloading is broken in some hardware drivers, and may impact performance with some specific NICs.
And
QuoteChecking this option will disable hardware large receive offloading (LRO). This offloading is broken in some hardware drivers, and may impact performance with some specific NICs.

to

QuoteThis add latency, and because all packets need to be sending out again, the stack have to split in different packets again before to hand them down to the NIC. Intel drivers readme include this note "The result of not disabling LRO when combined with ip forwarding or bridging can be low throughput or even a kernel panic." Also this breaks the end to end principle.

Or similar. I think it's more useful information. Taken from here: https://bsdrp.net/documentation/technical_docs/performance

Bzw: I wonder if the same is true for CRC offloading. Anyone knows?

no need to be so verbose.. i think it is fine as is.