Messages

1

24.1 Legacy Series / Re: Number of Undefined Variables and PHP errors

« on: January 20, 2024, 05:53:20 pm »

Here is another set of PHP warnings for each interface:

Code: [Select]

PHP Warning:  Undefined array key 0 in /usr/local/www/interfaces.php on line 479
PHP Warning:  Trying to access array offset on value of type null in /usr/local/www/interfaces.php on line 479
PHP Warning:  Undefined array key 0 in /usr/local/www/interfaces.php on line 489
PHP Warning:  Trying to access array offset on value of type null in /usr/local/www/interfaces.php on line 489
PHP Warning:  Undefined array key 0 in /usr/local/www/interfaces.php on line 490
PHP Warning:  Trying to access array offset on value of type null in /usr/local/www/interfaces.php on line 490
PHP Warning:  Undefined array key 0 in /usr/local/www/interfaces.php on line 491
PHP Warning:  Trying to access array offset on value of type null in /usr/local/www/interfaces.php on line 491
PHP Warning:  Undefined array key "ipaddrv6" in /usr/local/www/interfaces.php on line 2939
PHP Warning:  Undefined array key 0 in /usr/local/www/interfaces.php on line 3585
PHP Warning:  Trying to access array offset on value of type null in /usr/local/www/interfaces.php on line 3585
I currently don't have a solution to squash these Warnings.

2

24.1 Legacy Series / Number of Undefined Variables and PHP errors

« on: January 19, 2024, 10:04:11 pm »

I have been collecting a number of undefined variables in the following files:

• /usr/local/www/services_dhcpv6.php

             - $pdlen undefined at 498 and 501

• /usr/local/www/status_ntpd.php

             - $gps_ok undefined at 250

• /usr/local/www/widgets/widgets/ntp_status.widget.php

             - $_REQUEST['updateme'] is undefined at 36
             - $gps_ok undefined at 148

Code: [Select]

--- a/src/www/services_dhcpv6.php
+++ b/src/www/services_dhcpv6.php
@@ -70,6 +70,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') {
 $ifcfgip = $config['interfaces'][$if]['ipaddrv6'];
 $ifcfgsn = $config['interfaces'][$if]['subnetv6'];

+$pdlen = -1;
 if (isset($config['interfaces'][$if]['dhcpd6track6allowoverride'])) {
     list ($ifcfgip,, $ifcfgsn) = interfaces_primary_address6($if);
     $pdlen = calculate_ipv6_delegation_length($config['interfaces'][$if]['track6-interface']) - 1;

--- a/src/www/status_ntpd.php
+++ b/src/www/status_ntpd.php
@@ -31,6 +31,7 @@
 require_once("guiconfig.inc");
 require_once("interfaces.inc");

+$gps_ok = False;
 if (!isset($config['ntpd']['noquery'])) {
     exec("/usr/local/sbin/ntpq -pnw | /usr/bin/tail +3", $ntpq_output);
     $ntpq_servers = array();

--- a/src/www/widgets/widgets/ntp_status.widget.php
+++ b/src/www/widgets/widgets/ntp_status.widget.php
@@ -33,7 +33,8 @@
 require_once("guiconfig.inc");
 require_once("widgets/include/ntp_status.inc");

-if ($_REQUEST['updateme']) {
+$gps_ok = False;
+if (isset($_REQUEST['updateme'])) {
 //this block displays only on ajax refresh
     exec("/usr/local/sbin/ntpq -pn | /usr/bin/tail +3", $ntpq_output);
     $ntpq_counter = 0;

Noticed on my i7 12 core appliance, that the system temperatures were a bit off.
Each core pair 0:1, 2:3, etc. are displaying the same temp.  Also, cores 10, 11, and
12 followed core 1. So the sorting of the cores were not recognizing a numeric order.

My changes to fix the temperature display are:

Code: [Select]

--- a/src/opnsense/scripts/system/temperature.sh
+++ b/src/opnsense/scripts/system/temperature.sh
@@ -44,8 +44,6 @@ else
        # The grep is opportunistic, but at least we only grep the
        # variable names and not their content at the same time and
        # as long as we can find something that matches our search.
-       SYSCTLS=$(sysctl -aN | grep temperature)
-       if [ -n "${SYSCTLS}" ]; then
-               sysctl -e ${SYSCTLS} | sort
-       fi
+       sysctl -e dev.cpu | grep temperature | sort -t. -k3n
+       sysctl -e hw. | grep temperature | sort -t. -k4n
  fi

--- a/src/www/widgets/api/plugins/temperature.inc
+++ b/src/www/widgets/api/plugins/temperature.inc
@@ -46,9 +46,5 @@ function temperature_api()
         }
     }

-    usort($result, function ($item1, $item2) {
-        return strcmp(strtolower($item1['device']), strtolower($item2['device']                                                  ));
-    });
-
     return $result;
 }

On my motherboard, the hardware zone 0 temp is always a constant value.  So in my instance
I have dropped the second sysctl query and just rely on the first sysctl dev.cpu query.

3

Development and Code Review / Re: Custom build failed during building ports

« on: November 20, 2023, 04:35:15 pm »

I do git pulls regularly, but the config folder under tools that i was using wasn't tracking the changes in 23.7.  Maybe I'll change to local commits to 23.7.

Was just tying to track the development phase, originally had labeled the config folder "Future", but one of the build phases complained that it wasn't compliant with the MM.m format.  So Just picked the next release number :-).

4

Development and Code Review / Re: Custom build failed during building ports

« on: November 20, 2023, 04:12:16 pm »

Thanks.  New tothis building process, I copied the 23.7 config folder to a new one labeled 24.1

Need to attention to changes to the 23.7 folder.  Is there a better way to stay current?

Ron

5

Development and Code Review / Re: Custom build failed during building ports

« on: November 20, 2023, 03:09:38 pm »

Similar problem building nut 2.8.0_24:

configure: error: could not enable GSSAPI support
[20231120123557] ===> Script "configure" failed unexpectedly.
Please report the problem to lev@FreeBSD.org [maintainer] and attach the
"/usr/obj/usr/ports/www/neon/work/neon-0.32.5/config.log" including the output
of the failure of your make command. Also, it might be a good idea to provide
an overview of all packages installed on your system (e.g. a
/usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

6

Development and Code Review / Re: Custom build failed during building ports

« on: November 19, 2023, 05:50:48 pm »

Had a similar issue a few days ago.  Just retried that portion of the build and it progressed to completion. 

Try building again.