1
Development and Code Review / Re: nginx plugin
« on: September 20, 2018, 11:18:20 am »Quote
Websocket support will be in 1.1 (https://github.com/opnsense/plugins/pull/828)
Oh that is cool. Great!
Quote
For the location block: it looks very strange to me to include the hostname. Why?
I think it was more convention than anything else. I took the same sort of rules I used for nginx is the standalone instance and one of the cool things is nginx (like apache) can have multiple 'identites' in different config files which can be very handy. So if you are coming in as say mail.host.domain you get the webmaill forwarding, if you come in as dashboard.host.domain you get another service. All the $host does is make sure that the urls stay consistent I think.
I assume you knew this because you can allow multiple entries to be created though I am still unclear how they are all supposed to work together with the same nginx.conf file. Or maybe I am just misunderstanding how it is all parsed, it was very late last night when I started looking into it going off into the weeds.
Either way looks like it is shaping up nicely and I don't mind playing around with it on a non-production install and ironing out other edge cases.
Thanks.