Messages

1

Development and Code Review / Re: Integrate an important PPPoE patch

« on: July 19, 2017, 04:25:47 pm »

I've created a pull request

https://github.com/opnsense/core/pull/1730

2

Development and Code Review / Re: Integrate an important PPPoE patch

« on: July 19, 2017, 11:39:21 am »

ok, I've done it.

/usr/local/etc/inc/interfaces.inc

line 1575:

original:
        } elseif ($ppp['type'] == "pppoe") {
            $provider = isset($ppp['provider']) ? $ppp['provider'] : "";
            $mpdconf_arr[] = "set pppoe service \"{$provider}\"";
            $mpdconf_arr[] = "set pppoe iface {$port}";

modified:

        } elseif ($ppp['type'] == "pppoe") {
            $provider = isset($ppp['provider']) ? $ppp['provider'] : "";
            $mpdconf_arr[] = "set pppoe service \"{$provider}\"";
            $mpdconf_arr[] = "set pppoe iface {$port}";
         if (!empty($ppp['hostuniq'])) {
            $mpdconf_arr[] = "set host-uniq {$ppp["hostuniq"]}";
         }
-------------------------------------------------------------------------------

/usr/local/www/interfaces_ppps_edit.php

line 52:
original:
                        'apn', 'apnum', 'phone', 'connect-timeout', 'provider');
modified:
                        'apn', 'apnum', 'phone', 'connect-timeout', 'provider', 'hostuniq');

line 178:
original:
        $port_fields = array("localip", "gateway", "subnet", "bandwidth", "mtu", "mru", "mrru");   
modified:
        $port_fields = array("localip", "gateway", "subnet", "bandwidth", "mtu", "mru", "mrru", "hostuniq");

line 236:
added:
      $ppp['hostuniq'] = $pconfig['hostuniq'];

line 784:
added:
   <tr>
            <td><?=gettext("Host-Uniq"); ?></td>
       <td>
           <input name="hostuniq" class="intf_select_<?=$intf_idx;?>" type="text" value="<?=$pconfig['hostuniq'];?>" />
            </td>
     </div>
   </tr>

line 791:
added:
                              <li><?=gettext("Host-Uniq: Set ONLY if needed.");?></li>
-------------------------------------------------------------------------------


this should work, I don't know if someone wants to review this code and push to upstream....

3

Development and Code Review / Re: Integrate an important PPPoE patch

« on: July 18, 2017, 06:08:12 pm »

I've done some tweaks on "/usr/local/www/interfaces_ppps_edit.php" in order to add host-uniq directly from webgui.
You can see in the image posted on the left the webgui, on the right the config.xml


The problem now is to make this configuration be parsed and apply the "host-uniq" value to mpd_XXX.conf

4

Development and Code Review / Re: Integrate an important PPPoE patch

« on: July 17, 2017, 01:34:11 pm »

hi franco, the 17.7.r1 includes this pppoe patch?
If yes, it's in the standard kernel or I have to install the 17.1.7-pppoe?

@mleone87
How did you test connectivity without the custom field in the webgui?

thanks

5

Hardware and Performance / Re: qotom i5-5250U

« on: June 30, 2017, 11:44:45 am »

hi, I've bought it months ago and it works with pfsense and opnsense flawlessly.