nginx: sendfile gets periodically disabled in main config

[dinguz]

I have been playing around with nginx as a reverse proxy, and noticed something peculiar: every time I enable sendfile support in the main config page, it gets disabled automatically after some time. Is this expected behavior?
I have it enabled in the individual HTTP server entries as well.

[dinguz]

I believe I have found the cause, in this file:

Code Select Expand

/usr/local/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/settings.xml
this section is incorrect:

Code Select Expand

<field>
    <id>nginx.http.enabled</id>
    <label>Enable sendfile</label>
    <type>checkbox</type>
    <help>Enable sendfile support (faster).</help>
  </field>
it should read:

Code Select Expand

<field>
    <id>nginx.http.sendfile</id>
    <label>Enable sendfile</label>
    <type>checkbox</type>
    <help>Enable sendfile support (faster).</help>
  </field>
This naming mismatch causes the checkbox to be ineffective.
Would reporting it here be sufficient, or is official bug report in order?

[Patrick M. Hausen]

Reporting it here is not guaranteed to reach any of the developers, although it frequently does. So best to create an issue on github.

[dinguz]

Done: https://github.com/opnsense/core/issues/8176