[SOLVED] Reboot and an eroor in configd.py

Started by phoenix, January 04, 2016, 05:34:36 PM

Previous topic - Next topic
January 04, 2016, 05:34:36 PM Last Edit: January 10, 2016, 07:57:16 PM by phoenix
I'm currently on the latest 15.7.3 version and I did a reboot, the following error line appeared in the log file (this was retrieved from my Splunk syslog server):

Jan  4 17:27:10 192.168.1.1 Jan  4 17:28:05 configd.py: [648e0600-45de-4465-b512-2580c9251faa] Inline action failed at Traceback (most recent call last):   File "/usr/local/opnsense/service/modules/processhandler.py", line 488, in execute     return ph_inline_actions.execute(self, inline_act_parameters)   File "/usr/local/opnsense/service/modules/ph_inline_actions.py", line 52, in execute     filenames = tmpl.generate(parameters)   File "/usr/local/opnsense/service/modules/template.py", line 296, in generate     for filename in self._generate(template_name, create_directory):   File "/usr/local/opnsense/service/modules/template.py", line 226, in _generate     new_filename = filename.replace('[%s]' % target_filter, target_filters[target_filter][key]) TypeError: expected a string or other character buffer object

Is there any further information you need about this?

Happy New Year to everyone. :)

Regards


Bill

Hi Bill,

The best wishes to you too.

I think we found this issue a week ago, although I thought it was only affecting the development version at the time.
The problem was that the template engine tried to build files for unconfigured features, this commit https://github.com/opnsense/core/commit/1f7af3105e433bd28b078d32d4d9c99fa0747548 fixed it.

I'm not sure if this will make it into 15.7, but it shouldn't impose any real issues (other then the log message).

Regards,

Ad

January 04, 2016, 08:34:57 PM #2 Last Edit: January 10, 2016, 07:54:13 PM by phoenix
Hi Ad

Thanks for the update. No, it's not a problem for me but as I'm not a coder I never know if it's a major bug or something minor. :)
Regards


Bill

Ad was sad about being addressed as Franco. :D

I will push the fix with 15.7.24.

Quote from: franco on January 09, 2016, 12:10:51 AM
Ad was sad about being addressed as Franco. :D
Bummer! I'd just read one of your post and then replied to this, no excuse but I'll put it down to advancing age. :) My apologies to Ad for that mistake.
Regards


Bill

Usually he gets confused with Jos, which is kind of natural when you see the two. Internally, we sometimes refer to Ad as "the other Jos". ;)