106
Development and Code Review / Re: Theme Tukan - edited version
« on: February 27, 2021, 09:04:38 pm »
Thats really really great. should be in the core of opnsense.
Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
107
Development and Code Review / Re: Theme Tukan - edited version
« on: February 27, 2021, 07:34:13 pm »another wild idea for toggled-not-applied rules: what if we just start to rotate toggle icon? (of course it will work only until you refresh page by applying changes or manually)
no themes updates needed
I think your idea is also very good. I've now solved it with crossed out. Let's see how it works when you work with it.
108
Development and Code Review / Re: Theme Tukan - edited version
« on: February 27, 2021, 12:29:01 am »strike font in red definitely an option. This is the appearance AFTER disaableing, but BEFORE pressing "Apply", correct? :-)
i did a pull request and uploaded a lot of screenshots. i think it looks nice!
https://github.com/opnsense/plugins/pull/2249
109
Development and Code Review / Re: Theme Tukan - edited version
« on: February 26, 2021, 10:33:49 pm »strike font in red definitely an option. This is the appearance AFTER disaableing, but BEFORE pressing "Apply", correct? :-)
No, it has to be applied first to see this in the rule section.
Disable the nat rules shows the line before applying. so it is a Core sourcecode code thing
110
Development and Code Review / Re: Theme Tukan - edited version
« on: February 26, 2021, 05:22:51 pm »
my idea would not have been to mark the entire line but only the words except the first column and the last column because of the icons.
thus an additional note about what the gray line means would also be omitted.
first example is red and second is black (you can make the colors even better visible by choosing another color or a brighter one )
thus an additional note about what the gray line means would also be omitted.
first example is red and second is black (you can make the colors even better visible by choosing another color or a brighter one )
111
Development and Code Review / Re: Theme Tukan - edited version
« on: February 26, 2021, 02:34:16 pm »@opnsenseuser: the "(disabled)" is an option.
Would love to see the option @Fright proposed as a draft... ;-)
Thats a Good idea. But there has to be a Note at the bottom like the rule Icon Description therefore, so everybody knows what that means. And this description has to be done in the Core source.
112
Development and Code Review / Re: Theme Tukan - edited version
« on: February 25, 2021, 02:02:53 pm »I forwarded this to Martin, but his Mailbox is Full. :-(
:-D
Just test it with your themes, I found it difficult with different themes ;-)
Isn't there a way to kind of "grey-out" rules that are REALLY inactive?
can you draw your idea in the picture for me?
The rules which are disabled are in cicada and vicuna yellow. Do you think grey is bettet for a dark theme?
I like to be convinced. every solution that is better is taken.
113
Development and Code Review / Re: Theme Tukan - edited version
« on: February 25, 2021, 09:57:33 am »
I forwarded this to Martin, but his Mailbox is Full. :-(
114
Development and Code Review / Re: Theme Tukan - edited version
« on: February 25, 2021, 09:55:29 am »
I think this is a Rebellion-theme Problem. I forwarded this to Martin.
115
Development and Code Review / Re: Theme Tukan - edited version
« on: February 25, 2021, 09:41:02 am »What bugs me with different themes is the (non-existing/not logical) change in color of symbols for firewall rules when changed from enabled to disabled BEFORE pressing "Apply".
can you show me with a screenshot what you mean exactly?
116
Development and Code Review / Re: Theme Tukan - edited version
« on: February 25, 2021, 07:35:01 am »
and this
117
Development and Code Review / Re: Theme Tukan - edited version
« on: February 25, 2021, 07:34:47 am »
and this
118
Development and Code Review / Re: Theme Tukan - edited version
« on: February 25, 2021, 07:34:27 am »
Ok, i ended up with this
119
Development and Code Review / Re: Theme Tukan - edited version
« on: February 24, 2021, 02:49:05 pm »Font in opening post was best imho ;-)
Ok, i will Post the next Update soon
120
Development and Code Review / Re: Theme Tukan - edited version
« on: February 24, 2021, 11:57:53 am »
3rd