1
Development and Code Review / Access Servers - Radius: Adding default radius realm to configuration page
« on: April 02, 2020, 10:37:50 pm »
Hi Forum,
I've just created the ability to have OPNsense add a default realm to a user logging in via radius. Mainly for use with the captive portal. However I've got a couple of questions.
1. Firstly would anyone else find this functionality useful?
2. My changes are across the following files:
src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php
src/www/system_authservers.php
Which from my reading of the documentation span the old and new code bases. Is that correct?
As such I'm struggling to find where/how field validation is carried out. A pointer or two in the right
direction would be much appreciated.
3. What is the pull request process?
Is there a documented process? Apologies if I've missed it in the development documentation.
Is the best practice to post here for a code review first?
Many thanks in advance.
Martin
I've just created the ability to have OPNsense add a default realm to a user logging in via radius. Mainly for use with the captive portal. However I've got a couple of questions.
1. Firstly would anyone else find this functionality useful?
2. My changes are across the following files:
src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php
src/www/system_authservers.php
Which from my reading of the documentation span the old and new code bases. Is that correct?
As such I'm struggling to find where/how field validation is carried out. A pointer or two in the right
direction would be much appreciated.
3. What is the pull request process?
Is there a documented process? Apologies if I've missed it in the development documentation.
Is the best practice to post here for a code review first?
Many thanks in advance.
Martin