Messages

1

Development and Code Review / Re: Need Advice: Managing Configuration Files

« on: May 12, 2024, 12:33:11 pm »

I don't need to do that. There are group files with names containing uninterrupted numbering starting from 1. The number of these groups is stored in the global configuration file. The initial issue is that you can't simply delete a random group file and decrement the value in the global config by one, as it will disrupt the sequence of group file names, causing a service error. Ideally, we need to restore the sequence by automatically resaving the entries with the restored sequence in numbering. I don't know how to do this properly because I haven't seen such solutions in other plugins, and I'm not fully proficient in PHP. Therefore, I've decided to temporarily bypass this issue by disallowing the deletion of configs.

p.s.
Thank you for your help! I've simplified things significantly. In the view, I've restricted deletion of all entries except the last one. As a result, the sequence remains intact, and it's permitted to delete group entries, but only from the end of the list.

2

Development and Code Review / Re: Need Advice: Managing Configuration Files

« on: May 11, 2024, 09:08:54 pm »

I was looking at the bind and wireguard plugins for reference. However, they don't require strict file sequencing like this.

3

Development and Code Review / Re: Need Advice: Managing Configuration Files

« on: May 11, 2024, 06:54:13 pm »

Yes, the idea is promising! Thank you! So, this can be done, but then we'll need to address another issue. In the main service config, there's a parameter called 'filtergroups', which equals the number of groups. I've set it up to autofill using '{{ OPNsense.e2guardian.group.groups.group|length }}'. We'll need to adjust it to always increment this parameter by one when a new group is created. I think we could add a counter to the main model and increment it there when adding a new group, but how should we do it properly?

ps
I've considered that there might be issues with exporting and importing settings in the future. In that case, we might need to disallow the deletion of groups. However, on the other hand, it's also not ideal that entries can't be deleted.

p.p.s.
Ultimately, I'll disable the ability to delete groups and take the highest 'instance' value for the main config. Configurations for disabled groups will be rewritten to an inert state. Thanks a lot for the idea!

4

Development and Code Review / Re: Need Advice: Managing Configuration Files

« on: May 11, 2024, 06:05:18 pm »

From what I know, it doesn't support that and relies specifically on additional files and their sequence. Configuration files for groups (e2guardianfN.conf) don't contain sections.

5

Development and Code Review / Need Advice: Managing Configuration Files

« on: May 11, 2024, 04:35:58 pm »

Hello everyone! I've encountered an issue while developing a plugin and need your help. My task is as follows: I have a service that utilizes multiple configuration files, named in the format e2guardianfN.conf, where N is a sequential number starting from one. In my model, I've added an 'instance' field where the file number is inputted. However, the service is sensitive to the order of these files, and it's not possible to simply delete a random file without restoring the naming order. My idea is to modify entries with an 'instance' number greater than the one being deleted. But how can I do this in the most appropriate way? I'd appreciate any tips and advice!

Also, I've uploaded a draft of the code to GitHub. Here is the link: https://github.com/Gunior80/E2G-OPNsense