OPNsense Forum
English Forums => Development and Code Review => Topic started by: opnsenseuser on May 15, 2018, 06:07:33 pm
-
Hi Franco!
in the course of my training in the mvc of opnsense, I found the file, which is responsible for the firewall scheduler. I came across the problem when creating the cicada template, but ignored it for lack of time.
So that this value is not always displayed in white when deactivating a cell, it would be sufficient to set the value to "inherit" instead of "#FFF".
This would make the scheduler independent of the WEB template (GUI) and above all readable.
I attached a modified code screenshot and the screenshot of the original code. Incidentally, I've already tried it and it works flawlessly.
What do you think ?
best regards rené
-
I would suggest to make the code independent from colors but this change is very large, so I did not change that code.
-
I would suggest to make the code independent from colors but this change is very large, so I did not change that code.
A pity.
This leaves the problem that under templates such as cicada, rebellion the scheduler is difficult to read when deleting scheduler entries.
best regards rené
-
Hi guys,
Ideally, the ancient JS code surrounding the scheduler edit page should be replaced and adhere to bootstrap colour classes. But since we are not in an ideal world:
https://github.com/opnsense/core/commit/319a8bc
René, can you attach screenshots of one of your themes with and without the patch in place, I'm not entirely sure what it should look like.
Thank you,
Franco
-
Hi guys,
Ideally, the ancient JS code surrounding the scheduler edit page should be replaced and adhere to bootstrap colour classes. But since we are not in an ideal world:
https://github.com/opnsense/core/commit/319a8bc
René, can you attach screenshots of one of your themes with and without the patch in place, I'm not entirely sure what it should look like.
Thank you,
Franco
as desired the screenshot of cicada and rebellion theme.
And if you would change the value to "inherit" in the source code, then the cell will be displayed in the same background color after a double-click as the template specified. then the field would be readable again.
in tukan theme it is not so bad, because the foreground text is black and the background is very bright anyway.
best regards
rené
-
I think I just declared it bad.
But Fabian knows what I mean.
rené
-
@rene: try my patch here: https://github.com/opnsense/core/pull/2407 - you only have to patch your sass file to support the selectors as well. Then you can theme it however you like.
-
great work guys!!!! :-) incredible fast -> it is almost world record! ;)
Thanks to Franco, Fabian and Martin for the professional support.
I have sent martin the changes for tukan and cicada.
I think we made 3 really good themes for opnsense. although that's certainly not the most important thing for a firewall. but an important step.
best regards,
rené
Above all, I have to thank Martin very much, who is really always helpful and without him all my zeal would not be worth anything.
-
I hope your last theme problems are fixed now ;)
kind regards from Vorarlberg
Fabian
-
I hope your last theme problems are fixed now ;)
kind regards from Vorarlberg
Fabian
I hope so ;-)
regards from vienna
Rene
-
Fabian's change was merged to master. Thanks!
-
Great work guys i Sent The latest fixed scheduler Updates for tukan and cicada to Martin.
Would be Great if we can get this Versions to the current update.
Best regards
Rene
-
The scheduler fix for cicada and tukan will come later.
Thx Franco, Fabian and Martin for your Support.
Best regards
Rene
-
I'll try and PR these over the weekend.. Busy with real work the last few days.
-
no problem martin. there are more important things -> do not stress!!!!
-
thx martin
Regards rene